Compilation fixes for macOS #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please also target for galactic and ros2 so that those also get this change |
SteveMacenski
approved these changes
Jun 17, 2021
Contributor
Author
|
@SteveMacenski All set! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
This fixes #396, and slam-toolbox now builds on macOS! Proof with CI run: https://github.com/nkalupahana/ros2-foxy-macos/runs/2845420359?check_suite_focus=true
Let me know how you want me to get this into all of the branches as well. I'm happy to open multiple PRs to each branch and handle that like I've done in the past.