fix: resolve CS8607 for ValueObject with nullable value type underlying#931
Merged
SteveDunn merged 2 commits intoMay 6, 2026
Merged
Conversation
When the underlying type is a nullable value type (e.g. ushort?), EqualityComparer<T>.Default.GetHashCode gained a [DisallowNull] annotation on its parameter in .NET 10+. Passing a Nullable<T> value to it triggers compiler warning CS8607. Fix: detect when the underlying type IsNullableValueType() and emit Value is null ? 0 : Value.GetHashCode() instead of routing through EqualityComparer. This is null-safe and avoids the DisallowNull constraint entirely. Applied to both GenerateForAStruct and GenerateGetHashCodeForAClass. The class variant wraps in parentheses to ensure correct ^ precedence. Fixes #914 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…hCode Includes generated snapshots for handling nullable value types in struct and class variants, utilizing null-safe `GetHashCode` logic to avoid `DisallowNull` warnings.
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the underlying type is a nullable value type (e.g. ushort?), EqualityComparer.Default.GetHashCode gained a [DisallowNull] annotation on its parameter in .NET 10+. Passing a Nullable value to it triggers compiler warning CS8607.
Fix: detect when the underlying type IsNullableValueType() and emit
Value is null ? 0 : Value.GetHashCode()
instead of routing through EqualityComparer. This is null-safe and avoids the DisallowNull constraint entirely.
Applied to both GenerateForAStruct and GenerateGetHashCodeForAClass. The class variant wraps in parentheses to ensure correct ^ precedence.
Fixes #914