fix: PolyType [TypeShape] attribute and disable NRTs for the marshaler#846
Merged
SteveDunn merged 4 commits intoSteveDunn:mainfrom Oct 4, 2025
Merged
fix: PolyType [TypeShape] attribute and disable NRTs for the marshaler#846SteveDunn merged 4 commits intoSteveDunn:mainfrom
[TypeShape] attribute and disable NRTs for the marshaler#846SteveDunn merged 4 commits intoSteveDunn:mainfrom
Conversation
[TypeShape] attribute and disable NRTs for the marshaler
AArnott
approved these changes
Sep 25, 2025
Contributor
Author
|
@SteveDunn Could you please take a look here Steve? |
Contributor
Author
|
Just updated the snapshot. The pipeline should pass now, hopefully. |
Owner
|
Hi - thank you for the PR. Would you mind resetting all of the snapshot files by running |
Contributor
Author
|
Thank you @SteveDunn — that helped. There was a missing parenthesis I needed to sort out. |
SteveDunn
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see AArnott/Nerdbank.MessagePack#651 — goes back to #835
This PR fixes two things:
Nerdbank.MessagePack— and the culprit isKind = TypeShapeKind.Nonewithin the[TypeShape]attribute. I removed that.[ValueObject]'s underlying type is a reference type (e.g.string) — I wrapped the marshaler class in a#nullable disable/#nullable restorepair of preprocessors.I also made the marshaler class
sealedto improve perf a little bit as well.