Add dart sass to actions #213
Conversation
There was a problem hiding this comment.
Hey @domw95,
thank you very much for your time and doing this.
Also sorry that I come back to you so late 😓
Just two comments, otherwise I think we are good to go with that.
Haven't checked the outcome url yet (shoud be https://hugo-fresh-4zdfckl3b-stefmas-projects.vercel.app/). But at the first glance it looks good 👏
| @@ -14,9 +14,11 @@ jobs: | |||
| - name: Setup Hugo | |||
| uses: peaceiris/actions-hugo@v3 | |||
| with: | |||
| hugo-version: '0.110.0' | |||
| hugo-version: "0.110.0" | |||
There was a problem hiding this comment.
According to hugo docs, dart sass is compatible with 0.114.0.
Do we have to update the hugo-version here as well? 🤔
There was a problem hiding this comment.
Ahh I missed that, looks like that will need changing then. The action that just ran builds the old version so its not using dart-sass anyway
| extended: true | ||
|
|
||
| - uses: dw-labs-org/dart-sass-gha@v1 |
There was a problem hiding this comment.
Thanks for your efforts here to creating this action! Really appreciate it 🙏
However, I think using an action here is a bit overkill.
We can install it right out of the snap repo:
- name: Install Dart Sass
run: sudo snap install dart-sassThis is also what the hugo docs say 🙃 So I would follow that advise.
There was a problem hiding this comment.
That is what I thought... but I couldn't get it to work. Looking back I have a feeling it might have been a path issue so it might be a case of adding:
- run: echo "/snap/bin" >> $GITHUB_PATHWhich is easier to maintain than an action, although it was good to learn how to do it.
If you install hugo with a snap I think dart-sass is included so maybe that's even easier.
|
@domw95 are you still interested in fixing this PR ? 🙂 |
Added
to the actions that need it.
My editor seems to have formatted them as well, hence all the changes.
I've tried this with the htmltest action and it seems to work fine.
Needed for #212 to pass checks