Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading slash for image paths #203

Merged

Conversation

unstableunicorn
Copy link
Contributor

Fix for issue #202

Removed leading / on image paths, deployments to sites on subpaths now work correctly.
This was noticed when deploying to gitlab pages the images would not load, gitlab pages uses the following path convention:

https://<username>.gitlab.io/<repo>/

Updated comments in example hugo.yaml to now be consistent with updates to paths.

Copy link
Owner

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch! Thanks for this 🙏
The test page still looks good
https://hugo-fresh-unstableunicorn-fix-leading-slash-for-image-paths.vercel.app/

Let's ship it!

Thanks for the contribution!

@StefMa StefMa merged commit 100f20a into StefMa:master May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants