Skip to content

Add ping health contributor #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Add ping health contributor #1443

merged 4 commits into from
Jan 21, 2025

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jan 16, 2025

Description

Adds a ping contributor

Resolves #1439

Docs https://github.com/SteeltoeOSS/Documentation/pulls/340

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jan 16, 2025
@TimHess TimHess self-assigned this Jan 16, 2025
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from sealing internal type.

@bart-vmware

This comment was marked as resolved.

@TimHess TimHess marked this pull request as ready for review January 21, 2025 16:10
@TimHess TimHess requested a review from bart-vmware January 21, 2025 16:25
@TimHess TimHess merged commit 30c86a9 into main Jan 21, 2025
23 checks passed
@TimHess TimHess deleted the add_ping branch January 21, 2025 16:47
@TimHess TimHess added this to the 4.0.0-m1 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ping health contributor
2 participants