add Android as supported platform#23
Merged
Stebalien merged 1 commit intoStebalien:masterfrom May 3, 2022
Merged
Conversation
Contributor
Author
|
@Stebalien anything I can do to get this merged + a version bump? |
Stebalien
approved these changes
May 3, 2022
Owner
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to have better tests for this, but it's simple enough that it's unlikely to break if Linux is working...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't get most the tests working, since they rely on paths android doesn't have, but I confirmed locally that if
/var/tmpwere replaced with a path that exists (and android added to the relevantcfgstatements), all the tests do pass.