Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions for CI #110

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Use GitHub Actions for CI #110

merged 2 commits into from
Oct 21, 2021

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 21, 2021

Hi,

I found that CI has failed for a long time.

I replaced CI of this repository with GitHub Actions.

Pros are:

  • Anyone who has an account on GitHub can access the results. (CircleCI requires their account to see the results)
  • Variations of Windows/macOS/Linux workers can run with one workflow

I configured a new minimal workflow which runs on macOS/Windows/Linux with Rust toolchain stable and 1.36 (MSRV of this project).

And I confirmed all tests passed with my forked repository: https://github.com/rhysd/term-crate/actions/runs/1368569222

Stebalien
Stebalien approved these changes Oct 21, 2021
View reviewed changes
Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That'll make my life much easier.

@Stebalien Stebalien merged commit 4038d7f into Stebalien:master Oct 21, 2021
@rhysd
Copy link
Contributor Author

rhysd commented Oct 21, 2021

New workflow ran successfully on the merge commit. Would you disable CircleCI for this repository?

@Stebalien
Copy link
Owner

Already done 😄.

@rhysd rhysd mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysd @Stebalien