Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass on Rust 1.53 #109

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

syvb
Copy link
Contributor

@syvb syvb commented Apr 25, 2021

Since all warnings are denyed when cfg(test), new warnings in rustc make tests fail. A new warning was added to rustc, so they fail with warnings like this:

error: panic message is not a string literal
   --> src/terminfo/parm.rs:682:34
    |
682 |             assert!(res.is_ok(), res.err().unwrap());
    |                                  ^^^^^^^^^^^^^^^^^^
    |
    = note: this is no longer accepted in Rust 2021
help: add a "{}" format string to Display the message
    |
682 |             assert!(res.is_ok(), "{}", res.err().unwrap());
    |                                  ^^^^^

This fixes that by correcting the warnings, and tests now pass.

@Stebalien Stebalien merged commit cb740cc into Stebalien:master Apr 26, 2021
@Stebalien
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants