fix: don't claim 'too many temporary files exist' if a file already existed, once. #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xisted, once. Previously when creating a temporary file without any random characters in it, a loop would effectively run once and fail with the conclusion that a file could not be created because too many temporary files exist (2_147_483_648). Now it will return the original failure, which typically is that the file with the given name already existed. This can more easily happen on case-insentiive file systems, and the correct error message helps understanding what went wrong. See GitoxideLabs/gitoxide#595 for reference.
Stebalien
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when creating a temporary file without any random characters
in it, a loop would effectively run once and fail with the conclusion
that a file could not be created because too many temporary files exist
(2_147_483_648).
Now it will return the original failure, which typically is that the
file with the given name already existed.
This can more easily happen on case-insentiive file systems, and the
correct error message helps understanding what went wrong.
See GitoxideLabs/gitoxide#595 for reference.