Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NonSteamLaunchers as a Decky Plugin #527

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

moraroy
Copy link

@moraroy moraroy commented Jan 24, 2024

NonSteamLaunchers

Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder or separately and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, Origin, The EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher, Glyph and Minecraft. Now with SD Card Support. Now includes automatic game scanning for the the launchers.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@moraroy moraroy requested a review from a team as a code owner January 24, 2024 06:10
@moraroy
Copy link
Author

moraroy commented Jan 24, 2024

@Tormak9970 @TrainDoctor i think im ready now, sorry for all the mistakes before. this one is ready, just tested on stable and is working.

@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers looking for users to evaluate this plugin. Thanks.

@moraroy
Copy link
Author

moraroy commented Feb 15, 2024

@TrainDoctor hey train I have some big changes coming for this plugin in the next week or so, currently working on it as we speak. Just wanted to share.

@TrainDoctor
Copy link
Member

@TrainDoctor hey train I have some big changes coming for this plugin in the next week or so, currently working on it as we speak. Just wanted to share.

Do you think it's better to get those changes evaluated as a part of this PR or to get a known working version tested and out to users?

@moraroy
Copy link
Author

moraroy commented Feb 15, 2024

@TrainDoctor have no idea. Currently this pr works though! Didn't know what you meant by telling other users to test. I thought maybe you were going to delete the pr lol my bad brother

@TrainDoctor
Copy link
Member

@TrainDoctor have no idea. Currently this pr works though! Didn't know what you meant by telling other users to test. I thought maybe you were going to delete the pr lol my bad brother

PRs never get deleted just closed, but understandable. Not to worry for you.

@moraroy
Copy link
Author

moraroy commented Mar 20, 2024

@TrainDoctor hey train i had some weird conflicts but i believe i have fixed them... i was attempting to also update my pull request to the latest version with all the new changes but im not sure if my changes reflected that? if so i believe it is ready to go to testing!

@TrainDoctor
Copy link
Member

@TrainDoctor hey train i had some weird conflicts but i believe i have fixed them... i was attempting to also update my pull request to the latest version with all the new changes but im not sure if my changes reflected that? if so i believe it is ready to go to testing!

You were close but I pushed an update that should sort it now.

@moraroy
Copy link
Author

moraroy commented Mar 20, 2024

@TrainDoctor 😓 the push to update the submodule didn't go through I guess, it's showing the same version. Now that you fixed it though, I'll do another submodule plugin update.

@TrainDoctor
Copy link
Member

@TrainDoctor 😓 the push to update the submodule didn't go through I guess, it's showing the same version. Now that you fixed it though, I'll do another submodule plugin update.

Yeah so all you should need to do is update your main branch and the PR should pull that in automatically. I would recommend making a branch that's dedicated for updates to the Decky Store and pin your submodule to that so you can update your main branch independently and then merge changes into the store/store-submission branch (etc) whenever you make PRs like this. I don't know if this would be directly helpful to your situation though.

@moraroy
Copy link
Author

moraroy commented Jun 17, 2024

@AAGaming00 ive added the script and removed the RCE

@moraroy
Copy link
Author

moraroy commented Jun 19, 2024

@AAGaming00 another video has come.out hopefully this helps prove the plugin is working just came out a couple hours ago? https://youtu.be/0f7fw1WyW3Y

@TrainDoctor
Copy link
Member

@AAGaming00 another video has come.out hopefully this helps prove the plugin is working just came out a couple hours ago? https://youtu.be/0f7fw1WyW3Y

@moraroy I understand your reasoning. We still require that someone conduct a proper test of the plugin include a proper testing report here in case if something goes wrong we can go back to that tester and look into what happened.

@SteamDeckHomebrew/decky-testers please give this a test and verify basic functionality, thanks.

@TrainDoctor TrainDoctor dismissed AAGaming00’s stale review June 20, 2024 22:23

Stale, RCE removed.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moraroy script is not in "defaults" folder so it does not get copied into distributed plugin. Plop it in there and you should be golden for testing.

@githubUser01946
Copy link

I'm using this daily now.
Such a great plugin. Can't wait for none beta Decky users to get it!

@moraroy
Copy link
Author

moraroy commented Jun 20, 2024

@TrainDoctor gotcha, ok ill move it into defaults

@moraroy
Copy link
Author

moraroy commented Jun 21, 2024

@TrainDoctor should be good now i think? as long as i didnt bork anything lol

@moraroy
Copy link
Author

moraroy commented Jun 21, 2024

@AAGaming00 hey um i think the latest build in the testing store for some reason isn't building the new default folder with the script inside, so im going to try and push it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

None yet

7 participants