Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum R version in DESCRIPTION #376

Closed
amoeba opened this issue Feb 25, 2025 · 3 comments · Fixed by #377
Closed

Upgrade minimum R version in DESCRIPTION #376

amoeba opened this issue Feb 25, 2025 · 3 comments · Fixed by #377
Milestone

Comments

@amoeba
Copy link
Contributor

amoeba commented Feb 25, 2025

Hi pxmake team, while submitting our own package to CRAN today we got a note back about an issue in pxmake that looks like something you'll want to deal with eventually so I'm filing an issue and a PR in case it helps. The reason we got a note is that pxmake is a reverse-dependent of ours.

The issue CRAN notified of us was:

Package: pxmake
Check: DESCRIPTION meta-information
New result: NOTE
    Missing dependency on R >= 4.1.0 because package code uses the pipe
    |> or function shorthand \(...) syntax added in R 4.1.0.
    File(s) using such syntax:
      ‘px_add_totals.px.Rd’ ‘px_aggregallowed.px.Rd’ ‘px_autopen.px.Rd’
      ‘px_axis_version.px.Rd’ ‘px_baseperiod.px.Rd’ ‘px_cellnote.px.Rd’
      ‘px_cellnotex.px.Rd’ ‘px_cfprices.px.Rd’ ‘px_charset.px.Rd’
      ‘px_codepage.px.Rd’ ‘px_confidential.px.Rd’ ‘px_contact.px.Rd’
      ‘px_contents.px.Rd’ ‘px_contvariable.px.Rd’ ‘px_copyright.px.Rd’
      ‘px_creation_date.px.Rd’ ‘px_decimals.px.Rd’ ‘px_description.px.Rd’
      ‘px_descriptiondefault.px.Rd’ ‘px_domain.px.Rd’
      ‘px_elimination.px.Rd’ ‘px_infofile.px.Rd’ ‘px_language.px.Rd’
      ‘px_languages.px.Rd’ ‘px_last_updated.px.Rd’ ‘px_link.px.Rd’
      ‘px_map.px.Rd’ ‘px_matrix.px.Rd’ ‘px_micro.Rd’ ‘px_next_update.px.Rd’
      ‘px_note.px.Rd’ ‘px_notex.px.Rd’ ‘px_order.px.Rd’
      ‘px_precision.px.Rd’ ‘px_showdecimals.px.Rd’ ‘px_source.px.Rd’
      ‘px_stockfa.px.Rd’ ‘px_subject_area.px.Rd’ ‘px_subject_code.px.Rd’
      ‘px_tableid.px.Rd’ ‘px_timeval.px.Rd’ ‘px_title.px.Rd’
      ‘px_units.px.Rd’ ‘px_update_frequency.px.Rd’ ‘px_validate.Rd’
      ‘px_valuenote.px.Rd’ ‘px_valuenotex.px.Rd’ ‘px_values.px.Rd’
      ‘px_variable_label.px.Rd’ ‘px_variable_type.px.Rd’

CRAN very recently added a check for usage of the newer |> and \(...) operators, see https://stat.ethz.ch/pipermail/r-devel/2025-January/083793.html, and my guess is that they'll eventually flag pxmake because your minimum R version is set to >= 3.5.0.

I'll file a PR to update this in case you want to keep using the new operators.

Edit: You can see the NOTE directly on pxmake's check page here: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/pxmake-00check.html.

@johan-ejstrud
Copy link
Collaborator

Dear @amoeba thank you for the detailed issue and the PR.

I have to look a bit more closely at this. We might choose to use the magrittr pipe instead, since the package already imports it.

Thanks again.

@llrs
Copy link

llrs commented Mar 1, 2025

If it helps, pxmake has some packages without dependency requirements but the dependencies have some limits (required column). So in practice, your users already need to have these versions. I would say that increasing the R version requirement to 4.1 would be safe.

     name   op version    type package required
1 magrittr <NA>    <NA> Imports  pxmake    1.5.0
2        R   >=   3.5.0 Depends  pxmake      4.0
3    rlang <NA>    <NA> Imports  pxmake    1.1.1
4  stringi <NA>    <NA> Imports  pxmake    1.5.3
5   tibble <NA>    <NA> Imports  pxmake    3.2.0
6    vctrs <NA>    <NA> Imports  pxmake    0.6.4

@johan-ejstrud johan-ejstrud added this to the 0.16.0 milestone Mar 3, 2025
@johan-ejstrud
Copy link
Collaborator

Thanks for the input @llrs. I can see that pxmake already depends on arrow which depends on R version >= 4.0, so bumping to at least 4.0 is already required. We'll bump the requirement to 4.1 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants