-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade minimum R version in DESCRIPTION #376
Comments
Dear @amoeba thank you for the detailed issue and the PR. I have to look a bit more closely at this. We might choose to use the magrittr pipe instead, since the package already imports it. Thanks again. |
If it helps, pxmake has some packages without dependency requirements but the dependencies have some limits (required column). So in practice, your users already need to have these versions. I would say that increasing the R version requirement to 4.1 would be safe.
|
Thanks for the input @llrs. I can see that pxmake already depends on arrow which depends on R version >= 4.0, so bumping to at least 4.0 is already required. We'll bump the requirement to 4.1 👌 |
Hi pxmake team, while submitting our own package to CRAN today we got a note back about an issue in pxmake that looks like something you'll want to deal with eventually so I'm filing an issue and a PR in case it helps. The reason we got a note is that pxmake is a reverse-dependent of ours.
The issue CRAN notified of us was:
CRAN very recently added a check for usage of the newer
|>
and\(...)
operators, see https://stat.ethz.ch/pipermail/r-devel/2025-January/083793.html, and my guess is that they'll eventually flag pxmake because your minimum R version is set to >= 3.5.0.I'll file a PR to update this in case you want to keep using the new operators.
Edit: You can see the NOTE directly on pxmake's check page here: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/pxmake-00check.html.
The text was updated successfully, but these errors were encountered: