Allow specifying hostname for Hapi servers. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And specify it as "localhost" for the servers that are started by the integration tests. Some of the integration tests were failing for me because: - My laptop is configured with both IPv4 and IPv6 for localhost (and non-localhost, too, but that's not relevant here). - Hapi binds to 0.0.0.0 by default ([API docs](https://hapi.dev/api/?v=20.2.2#-serveroptionsaddress), [code reference](https://github.com/hapijs/hapi/blob/b8ba0adc7c3255995cb56a9a740c4f9750b80e6b/lib/core.js#L339)). - That's an IPv4 address so the server will only accept connections over IPv4 and not IPv6. - Our integration test config specifies `localhost` when creating the clients for connecting to these servers. - `localhost` can resolve to an IPv6 address. - Node before v17 sorted IP addresses from the name resolver so IPv4 addresses were first but Node v17 and newer returns them in the order returned by the resolver ([GitHub comment](nodejs/node#40537 (comment)), [relevant PR](nodejs/node#39987), it's the first "Other Notable Changes" in [the v17.0.0 release notes](https://nodejs.org/en/blog/release/v17.0.0/#other-notable-changes)). Apparently on my laptop an IPv6 address is returned before an IPv4 address. Alternatively I could have changed the test config so clients connect to 127.0.0.1. I like this change because: - It's a good idea to allow users to specify the address to bind to. - Now the test servers will bind to localhost instead of 0.0.0.0 and it's nice to avoid accepting outside connections when possible.
strmer15
approved these changes
Jul 6, 2022
markdoliner-doma
deleted the
markdoliner-doma/Allow_specifying_hostname_for_hapi_servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And specify it as "localhost" for the servers that are started by the integration tests.
Some of the integration tests were failing for me because:
localhostwhen creating the clients for connecting to these servers.localhostcan resolve to an IPv6 address.Alternatively I could have changed the test config so clients connect to 127.0.0.1. I like this change because: