[pull] main from open-telemetry:main#328
Merged
Merged
Conversation
This is the next step towards #13106 It introduces private `switchDictionary` methods for all profile structs, so their base dictionary can be switched, which is a requirement (and maybe the biggest bit) of merging profiles. Right now, the private method isn't called yet, because this PR is already very big, and I believe introducing `MergeTo` should be in another PR. But the gist is that to merge profiles together, we need to change the base dictionary for the profiles that are being moved before we can merge the two slices of resource profiles into one.
#### Description Implement scraper for Profiles. This will help implement receiver parts like open-telemetry/opentelemetry-collector-contrib#42843. --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Adds Profiles scraping support to xscraper and introduces dictionary-switching across pprofile types to enable future profile merging and receiver scraping of profiles.
New Features
Enhancements
Written for commit 716e11a. Summary will update automatically on new commits.