Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Use the provided 'sourceFolder' property to generate the test folder #1

Closed
wants to merge 1 commit into from

Conversation

Starkie
Copy link
Owner

@Starkie Starkie commented Oct 31, 2021

Hi all!

This issue is regarding the csharp-netcore generator. There is a bit of an inconsistency in how the test folders are generated when the sourceFolder property is provided. For example:

  • Set the option sourceFolder to anything other than src.
    • In this case, I left it empty: --additional-properties=sourceFolder=""
  • Generate the client
  • See that the client was generated in the provided sourceFolder... but the tests where generated in src:
    image

In the AbstractCSharpCodegen.java, there is a TODO a few years old saying that a separate option for testFolder could be added:
https://github.com/OpenAPITools/openapi-generator/blob/8551b0af492286a431c95ce3a37d7edf1ef4870a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java#L73-L75

Until that is implemented, I created a little workaround, assigning the provided sourceFolder parameter to the testFolder.

With this change, the projects are generated as expected:
image

Related issue: OpenAPITools#1390

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Starkie Starkie changed the title [csharp] Fix generation inconsistency of client's test folder [csharp] Use the provided 'sourceFolder' property to generate the test folder Oct 31, 2021
@Starkie Starkie changed the base branch from master to 6.0.x October 31, 2021 10:17
* Use the specified 'sourceFolder' from additional properties for the 'testFolder' property.
@Starkie Starkie force-pushed the csharp/fix-test-folder-inconsistency branch from 5ac1318 to 94c741e Compare October 31, 2021 10:19
@Starkie Starkie closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant