Bump rubocop from 1.55.0 to 1.55.1 #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
gem compare --diff rubocop 1.55.0 1.55.1Compared versions: ["1.55.0", "1.55.1"]
DIFFERENT files:
1.55.0->1.55.1:
* Changed:
lib/rubocop/cop/base.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/base.rb 2023-08-01 02:03:41.999696945 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/base.rb 2023-08-01 02:03:42.311699797 +0000
@@ -56 +56 @@
- # @return [Array<RuboCop::Cop::Cop>]
+ # @return [Array<RuboCop::Cop::Base>]
lib/rubocop/cop/bundler/ordered_gems.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/bundler/ordered_gems.rb 2023-08-01 02:03:41.999696945 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/bundler/ordered_gems.rb 2023-08-01 02:03:42.315699834 +0000
@@ -22 +22,9 @@
- # # good only if TreatCommentsAsGroupSeparators is true
+ # @example TreatCommentsAsGroupSeparators: true (default)
+ # # good
+ # # For code quality
+ # gem 'rubocop'
+ # # For tests
+ # gem 'rspec'
+ #
+ # @example TreatCommentsAsGroupSeparators: false
+ # # bad
lib/rubocop/cop/gemspec/ordered_dependencies.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/gemspec/ordered_dependencies.rb 2023-08-01 02:03:42.007697018 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/gemspec/ordered_dependencies.rb 2023-08-01 02:03:42.319699870 +0000
@@ -48 +48,9 @@
- # # good only if TreatCommentsAsGroupSeparators is true
+ # @example TreatCommentsAsGroupSeparators: true (default)
+ # # good
+ # # For code quality
+ # spec.add_dependency 'rubocop'
+ # # For tests
+ # spec.add_dependency 'rspec'
+ #
+ # @example TreatCommentsAsGroupSeparators: false
+ # # bad
lib/rubocop/cop/internal_affairs/example_description.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/internal_affairs/example_description.rb 2023-08-01 02:03:42.011697055 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/internal_affairs/example_description.rb 2023-08-01 02:03:42.323699907 +0000
@@ -49 +49,2 @@
- /^(does not|doesn't) add (a|an|any )?offense/
+ /^(does not|doesn't) add (a|an|any )?offense/,
+ /^accepts\b/
lib/rubocop/cop/layout/space_around_method_call_operator.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/layout/space_around_method_call_operator.rb 2023-08-01 02:03:42.031697237 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/layout/space_around_method_call_operator.rb 2023-08-01 02:03:42.343700090 +0000
@@ -22 +22 @@
- # RuboCop:: Cop:: Cop
+ # RuboCop:: Cop:: Base
@@ -34 +34 @@
- # RuboCop::Cop::Cop
+ # RuboCop::Cop::Base
lib/rubocop/cop/mixin/def_node.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/mixin/def_node.rb 2023-08-01 02:03:42.071697603 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/mixin/def_node.rb 2023-08-01 02:03:42.503701553 +0000
@@ -22 +22 @@
- (send nil? {:private :protected} ({def defs} ...))
+ (send nil? {:private :protected :private_class_method} ({def defs} ...))
lib/rubocop/cop/style/arguments_forwarding.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/style/arguments_forwarding.rb 2023-08-01 02:03:42.087697749 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/style/arguments_forwarding.rb 2023-08-01 02:03:42.575702211 +0000
@@ -243,2 +243,2 @@
- # @!method find_forwarded_rest_arg(node, rest_name)
- def_node_search :find_forwarded_rest_arg, '(splat (lvar %1))'
+ # @!method forwarded_rest_arg?(node, rest_name)
+ def_node_matcher :forwarded_rest_arg?, '(splat (lvar %1))'
@@ -246,2 +246,2 @@
- # @!method find_forwarded_kwrest_arg(node, kwrest_name)
- def_node_search :find_forwarded_kwrest_arg, '(kwsplat (lvar %1))'
+ # @!method extract_forwarded_kwrest_arg(node, kwrest_name)
+ def_node_matcher :extract_forwarded_kwrest_arg, '(hash <$(kwsplat (lvar %1)) ...>)'
@@ -249,2 +249,2 @@
- # @!method find_forwarded_block_arg(node, block_name)
- def_node_search :find_forwarded_block_arg, '(block_pass {(lvar %1) nil?})'
+ # @!method forwarded_block_arg?(node, block_name)
+ def_node_matcher :forwarded_block_arg?, '(block_pass {(lvar %1) nil?})'
@@ -265 +265 @@
- find_forwarded_rest_arg(@send_node, @rest_arg_name).first
+ arguments.find { |arg| forwarded_rest_arg?(arg, @rest_arg_name) }
@@ -271 +271 @@
- find_forwarded_kwrest_arg(@send_node, @kwrest_arg_name).first
+ arguments.filter_map { |arg| extract_forwarded_kwrest_arg(arg, @kwrest_arg_name) }.first
@@ -277 +277 @@
- find_forwarded_block_arg(@send_node, @block_arg_name).first
+ arguments.find { |arg| forwarded_block_arg?(arg, @block_arg_name) }
@@ -290,0 +291,4 @@
+
+ def arguments
+ @send_node.arguments
+ end
lib/rubocop/cop/style/mixin_grouping.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/style/mixin_grouping.rb 2023-08-01 02:03:42.251699249 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/style/mixin_grouping.rb 2023-08-01 02:03:42.599702430 +0000
@@ -43 +43 @@
- next unless MIXIN_METHODS.include?(macro.method_name)
+ next if !MIXIN_METHODS.include?(macro.method_name) || macro.arguments.empty?
lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb 2023-08-01 02:03:42.267699395 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/style/return_nil_in_predicate_method_definition.rb 2023-08-01 02:03:42.615702577 +0000
@@ -79,0 +80,2 @@
+ return body if body.nil_type?
+ return unless body.begin_type?
lib/rubocop/cop/variable_force/assignment.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/cop/variable_force/assignment.rb 2023-08-01 02:03:42.283699541 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/cop/variable_force/assignment.rb 2023-08-01 02:03:42.627702686 +0000
@@ -122,3 +122 @@
- return nil unless node.parent&.for_type?
-
- node.parent
+ node.ancestors.find(&:for_type?)
lib/rubocop/version.rb
--- /tmp/d20230801-2561-ga6trp/rubocop-1.55.0/lib/rubocop/version.rb 2023-08-01 02:03:42.299699688 +0000
+++ /tmp/d20230801-2561-ga6trp/rubocop-1.55.1/lib/rubocop/version.rb 2023-08-01 02:03:42.643702833 +0000
@@ -6 +6 @@
- STRING = '1.55.0'
+ STRING = '1.55.1' |
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.55.1
branch
from
2ebbba4
to
035be3c
Compare
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.55.0 to 1.55.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.55.0...v1.55.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.55.1
branch
from
035be3c
to
985cffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.55.0 to 1.55.1.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
000ae57Cut 1.55.189c3045Update Changelog6e01713[Fix #12079] Fix an error forStyle/MixinGroupingee26d06[Fix #12082] Fix an error forLint/UselessAssignment59e940bUse RuboCop RSpec 2.2328e1456MakeInternalAffairs/ExampleDescriptionaware of an incorrect term2e1d3f9Fix a typo24f6e99[Fix #12070] Fix false positive inStyle/ArgumentsForwarding14e81ad[Fix #12068] Fix a false positive for `Style/ReturnNilInPredicateMethodDefini...d5b52dc[Docs] Tweak examples forBundler/OrderedGemsand `Gemspec/OrderedDependenc...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)