[StarRocks On ES] Support array format. #9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run starrocks_clang-format |
Signed-off-by: Smith Cruise <[email protected]>
imay
reviewed
Aug 6, 2022
imay
reviewed
Aug 9, 2022
| array = down_cast<ArrayColumn*>(column); | ||
| } | ||
|
|
||
| auto* offsets = array->offsets_column().get(); |
There was a problem hiding this comment.
Should define offsets when using it to understand easily.
RowenWoo
suggested changes
Aug 9, 2022
Smith-Cruise
changed the title
RowenWoo
reviewed
Aug 9, 2022
RowenWoo
suggested changes
Aug 9, 2022
imay
approved these changes
Aug 10, 2022
|
run starrocks_admit_test |
|
@Mergifyio backport branch-2.1 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit 6ae4a62) # Conflicts: # be/test/CMakeLists.txt
✅ Backports have been created
|
Smith-Cruise
added a commit
to Smith-Cruise/starrocks
that referenced
this pull request
Aug 10, 2022
7 tasks
|
@Mergifyio backport branch-2.3 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit 6ae4a62)
✅ Backports have been created
|
|
@Mergifyio backport branch-2.4 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit 6ae4a62)
✅ Backports have been created
|
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit 6ae4a62)
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit 6ae4a62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support array format in ES.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Checklist: