[BugFix] test isolation workgroup manager#67489
Open
eshishki wants to merge 1 commit intoStarRocks:mainfrom
Open
[BugFix] test isolation workgroup manager#67489eshishki wants to merge 1 commit intoStarRocks:mainfrom
eshishki wants to merge 1 commit intoStarRocks:mainfrom
Conversation
ResourceGroupUsageRecorderTest was replacing the global workgroup_manager without calling start(), leaving driver_executor as nullptr. This caused subsequent tests (test_two_operatories, PipeLineFileScanNodeTest) to crash when run in the same process without gtest-parallel isolation. Changes: - Save and restore original workgroup_manager in ResourceGroupUsageRecorderTest - Call start() on the new workgroup_manager to initialize executors - Add set_workgroup() call in PipeLineFileScanNodeTest setup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
eshishki
force-pushed
the
fix/test-isolation-workgroup-manager
branch
from
ffebe53 to
0545875
Compare
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix test isolation issues introduced in #66690 and #63956.
When tests run in the same process (without gtest-parallel),
ResourceGroupUsageRecorderTest replaces workgroup_manager without calling
start(), leaving driver_executor as nullptr. This causes subsequent tests
to crash with nullptr dereference.
Changes
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Ensures test isolation and proper workgroup setup to avoid nullptr crashes across tests.
exec_env._workgroup_managerwith a started instance, then restore the original at the end_fragment_ctx->set_workgroup(ExecEnv::GetInstance()->workgroup_manager()->get_default_workgroup())inSetUp()Written by Cursor Bugbot for commit 0545875. This will update automatically on new commits. Configure here.