[UT] Remove potentially buggy SQL test case for mem_pool property of resource groups (backport #66104)#66531
Merged
wanpengfei-git merged 1 commit intobranch-4.0from Dec 9, 2025
Conversation
23 tasks
Contributor
Author
🧪 CI InsightsHere's what we observed from your CI run for dccc4eb. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
ignore merge 4.0.3 |
alvin-celerdata
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
I recently added E2E SQL test cases for testing the mem_pool property.
One of the test cases has an incorrect regex.
The intention was to assert that the expression cannot be matched in the result.
It instead tries to match a single character that is not present in the brackets.
The correct regex should use a negative lookahead to implement the intended behavior.
The test case, however, does not fail, as the result coincidentally does not start with any of these characters.
What I'm doing:
The check is actually redundant, as we already assert that the resource group was not created in the previous check.
Instead of adding another complicated regex with negative lookaheads, I am simply removing it.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Removes an incorrect regex-based assertion and a duplicate
show verbose resource groups allcall from the mem_pool resource group test.R/test_create_two_resource_groups_with_mem_pool_different_mem_limitthat attempted to verify absence inshow verbose resource groups alloutput.T/test_create_two_resource_groups_with_mem_pool_different_mem_limitby removing a duplicateshow verbose resource groups allcall, leaving a single invocation.Written by Cursor Bugbot for commit eef6213. This will update automatically on new commits. Configure here.
This is an automatic backport of pull request #66104 done by [Mergify](https://mergify.com).