Support custom catalog for iceberg external table #5117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caneGuy
reviewed
Apr 20, 2022
caneGuy
changed the title
DorianZheng
reviewed
Apr 20, 2022
fe/fe-core/src/main/java/com/starrocks/catalog/IcebergTable.java
Outdated
Show resolved
Hide resolved
imay
reviewed
Apr 20, 2022
fe/fe-core/src/main/java/com/starrocks/catalog/IcebergResource.java
Outdated
Show resolved
Hide resolved
Contributor
|
I have left a comment, rest LGTM. |
imay
reviewed
Apr 20, 2022
fe/fe-core/src/main/java/com/starrocks/catalog/IcebergResource.java
Outdated
Show resolved
Hide resolved
| throw new DdlException(ICEBERG_IMPL + " must be set in properties"); | ||
| } | ||
| try { | ||
| Thread.currentThread().getContextClassLoader().loadClass(catalogImpl); |
Contributor
There was a problem hiding this comment.
This is just to verify whether the jvm has loaded the custom class when create customer iceberg resource？ If fe restarts and the loadClass() method will not be called.
Contributor
There was a problem hiding this comment.
Are there other considerations here? In fact, there is no need to restart fe by dynamically loading the custom jar.
Contributor
Author
|
run starrocks_fe_unittest |
caneGuy
previously approved these changes
Apr 22, 2022
DorianZheng
reviewed
Apr 22, 2022
fe/fe-core/src/main/java/com/starrocks/catalog/IcebergTable.java
Outdated
Show resolved
Hide resolved
DorianZheng
previously approved these changes
Apr 22, 2022
Contributor
DorianZheng
left a comment
DorianZheng
left a comment
There was a problem hiding this comment.
I have left one comment, rest LGTM
Collaborator
[FE PR Coverage check]😞 fail : 26 / 42 (61.90%) file detail
|
caneGuy
approved these changes
Apr 23, 2022
imay
approved these changes
Apr 24, 2022
blackstar-baba
pushed a commit
to blackstar-baba/starrocks
that referenced
this pull request
Apr 28, 2022
Add support for custom catalog which can be defined by users themselves when creating iceberg external table.
The custom catalog should be in the form of IcebergHiveCatalog, in other words extending BaseMetastoreCatalog and implementing IcebergCatalog. The catalog JAR should be placed into each fe/lib directory, and FE has to be restarted before custom catalog works.
Usage:
```sql
CREATE EXTERNAL RESOURCE "iceberg0"
PROPERTIES (
"type" = "iceberg",
"starrocks.catalog-type"="CUSTOM",
"iceberg.catalog-impl"="{The full class name of custom catalog}"
);
```
Extra config users defined can be added in table properties when executing CREATE EXTERNAL TABLE, see StarRocks#2225.
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
Signed-off-by: EsoragotoSpirit <wanglichen@starrocks.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
Signed-off-by: EsoragotoSpirit <wanglichen@starrocks.com> (cherry picked from commit 8c46037) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
Signed-off-by: EsoragotoSpirit <wanglichen@starrocks.com> (cherry picked from commit 8c46037) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
Signed-off-by: EsoragotoSpirit <wanglichen@starrocks.com> (cherry picked from commit 8c46037) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
Signed-off-by: EsoragotoSpirit <wanglichen@starrocks.com> (cherry picked from commit 8c46037) Co-authored-by: 絵空事スピリット <wanglichen@starrocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #3826
Problem Summary(Required) ：
Add support for custom catalog which can be defined by users themselves when creating iceberg external table.
The custom catalog should be in the form of IcebergHiveCatalog, in other words extending BaseMetastoreCatalog and implementing IcebergCatalog. The catalog JAR should be placed into each fe/lib directory, and FE has to be restarted before custom catalog works.
Usage:
Extra config users defined can be added in table properties when executing CREATE EXTERNAL TABLE, see #2225.