-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix be exit probelm #44162
[BugFix] fix be exit probelm #44162
Conversation
Signed-off-by: before-Sunrise <[email protected]>
what PR introduced this exit core? |
added in description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trueeyu how can we add some force checks on this thread pool cleanup so it can be found at the earliest.
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
@mergify backport branch-3.3 |
✅ Backports have been created
|
Signed-off-by: before-Sunrise <[email protected]> (cherry picked from commit 84a6e96)
Signed-off-by: before-Sunrise <[email protected]>
) Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
Signed-off-by: before-Sunrise <[email protected]>
Co-authored-by: before-Sunrise <[email protected]>
Why I'm doing:
introduced by #42351
https://github.com/StarRocks/StarRocksTest/issues/7060 one of its' problem is be can not exit gracefully:
p (ThreadPool)(0x61600010d780)
What I'm doing:
becase ThreadPool has CoreLocalCounter as member variable, so every ThreadPool have to be released before CoreLocalValueController which is a static single instance. I just reset two ThreadPool which use smart pointer in ExecEnv::destory, so these two thread pools will be released before CoreLocalValueController
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: