-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tool] Update tool chain and dev env dockerfiles #43100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
changed the title
Update tool chain and dev env dockerfiles
[Tool] Update tool chain and dev env dockerfiles
Mar 25, 2024
chaoyli
reviewed
Mar 25, 2024
fieldsfarmer
force-pushed
the
kw/dev-env
branch
from
March 25, 2024 21:53
72ac513
to
0befc8d
Compare
kevincai
reviewed
Mar 26, 2024
Signed-off-by: Kaiwei Wang <[email protected]>
Signed-off-by: Kaiwei Wang <[email protected]>
Signed-off-by: Kaiwei Wang <[email protected]>
Signed-off-by: Kaiwei Wang <[email protected]>
Signed-off-by: Kaiwei Wang <[email protected]>
fieldsfarmer
force-pushed
the
kw/dev-env
branch
from
March 26, 2024 18:08
1933072
to
b3aa475
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
approved these changes
Mar 27, 2024
chaoyli
approved these changes
Mar 27, 2024
@mergify backport 3.1 3.2 |
❌ No backport have been created
GitHub error:
GitHub error: |
@mergify backport branch-3.1 branch-3.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Kaiwei Wang <[email protected]> (cherry picked from commit 16a8395) # Conflicts: # docker/dockerfiles/toolchains/toolchains-ubuntu.Dockerfile
31 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Kaiwei Wang <[email protected]> (cherry picked from commit 16a8395)
31 tasks
kevincai
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Kaiwei Wang <[email protected]> (cherry picked from commit 16a8395)
kevincai
pushed a commit
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Kaiwei Wang <[email protected]> (cherry picked from commit 16a8395)
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 28, 2024
…43219) Co-authored-by: Kaiwei Wang <[email protected]>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
We need to download some artifacts from github private repositories. Meanwhile we wish to align our code with StarRocks (instead of using our own docker file). This change could also help other teams as they are quite general.
What I'm doing:
gh
in the tool chain image docker file to help us make github related operations more easily.GITHUB_TOKEN
in the dev env image docker file to help us download artifacts in github private repositories.What type of PR is this:
Does this PR entail a change in behavior?
Checklist:
Bugfix cherry-pick branch check: