[BugFix] Recalculate max_continuous_version after schema change finished (backport #28473) #28512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…hed (#28473) We will create a new tablet for each original tablet and we will write original tablet and new tablet during schema change. We will construct a `version_graph` to keep versions info for each table and the following code is how to update `version_graph`: ``` void VersionGraph::add_version_to_graph(const Version& version) { _add_version_to_graph(version); if (version.first == _max_continuous_version + 1) { _max_continuous_version = _get_max_continuous_version_from(_max_continuous_version + 1); } else if (version.first == 0) { // We need to reconstruct max_continuous_version from zero if input version is starting from zero // e.g. // 1. Tablet A is doing schema change // 2. We create a new tablet B releated A, and we will create a initial rowset and _max_continuous_version // will be updated to 1 // 3. Tablet A has a rowset R with version (0, m) // 4. Schema change will try convert R // 5. The start version of R (0) is not equal to `_max_continuous_version + 1`, and the _max_continuous_version // will not update _max_continuous_version = _get_max_continuous_version_from(0); } } ``` There exists a scenario where _max_continuous_version cannot be updated correctly e.g. 1. create a new tablet `t2` for origin tablet `t1` during schema change and `t2` has version 91,92,93,95,96,97,98. version 94 write failed. 2. when running schema change job, alter version is 98 and `t1` has version [0-90], [91-96], 97, 98 3. `max_continuous_version` of `t2` is 0 before convert rowset. After convert version [0-90], `max_continuous_version` is update to 93 because `t2` has version 91-93 before. 4. `max_continuous_version` don't update because the left rowsets version is not satisfy update condition(version.fisrt == 0 or version.first == _max_continuous_verison + 1). So the `max_continuous_version` will keep 93 after convert rowset finished. 5. we will check the max_continuous_version of `t2` at last and it should not less than alter version. But max_continuous_version(93) is less than alter version(98), so the alter job failed at last. The main reason is we don't update `_max_continuous_version` correctly during alter job, we should recalculate the `max_continuous_version` after rowset conversion. --------- Signed-off-by: zhangqiang <[email protected]> (cherry picked from commit bbedba4) # Conflicts: # be/src/storage/tablet.h
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
[FE PR Coverage Check]😍 pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #28473 done by Mergify.
Cherry-pick of bbedba4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com