Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Do not display type when table comment is empty #24803

Merged
merged 3 commits into from
Jun 7, 2023
Merged

[Enhancement] Do not display type when table comment is empty #24803

merged 3 commits into from
Jun 7, 2023

Conversation

Astralidea
Copy link
Contributor

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@Astralidea
Fix.
e535199 
Signed-off-by: Astralidea <[email protected]>
@Astralidea
Fix.
e8e06e5 
Signed-off-by: Astralidea <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Table.java 1 1 100.00% []

@Astralidea Astralidea enabled auto-merge (squash) June 7, 2023 13:16
@Astralidea Astralidea merged commit e770adb into StarRocks:main Jun 7, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Jun 7, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jun 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 7, 2023
@Astralidea @mergify
[Enhancement] Do not display type when table comment is empty (#24803)
31bf4e2 
Fixes #issue

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit e770adb)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/analysis/ShowCreateMaterializedViewStmtTest.java
#	test/sql/test_default_enable_replicated_storage/R/test_enable_mv
#	test/sql/test_materialized_column/R/test_materialized_column
#	test/sql/test_random_distribution/R/test_random_distribution
@mergify mergify bot mentioned this pull request Jun 7, 2023
Closed
mergify bot pushed a commit that referenced this pull request Jun 7, 2023
@Astralidea @mergify
[Enhancement] Do not display type when table comment is empty (#24803)
5f791c8 
Fixes #issue

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit e770adb)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/analysis/ShowCreateMaterializedViewStmtTest.java
#	test/sql/test_default_enable_replicated_storage/R/test_enable_mv
#	test/sql/test_materialized_column/R/test_materialized_column
#	test/sql/test_random_distribution/R/test_random_distribution
@mergify mergify bot mentioned this pull request Jun 7, 2023
Closed
This was referenced Jun 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@Astralidea Astralidea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Astralidea @wanpengfei-git @wyb @gengjun-git