Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support alter materialized view to active #24001

Merged
merged 3 commits into from
May 24, 2023
Merged

[Enhancement] Support alter materialized view to active #24001

merged 3 commits into from
May 24, 2023

Conversation

Astralidea
Copy link
Contributor

Fixes #23304

@Astralidea Astralidea requested a review from a team as a code owner May 23, 2023 13:04
@github-actions
Copy link

github-actions bot commented May 23, 2023 •
edited by Astralidea
Loading

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@Astralidea Astralidea changed the title Support alter materialized view to active [Enhancement] Support alter materialized view to active May 23, 2023
@Astralidea
Fix UT.
69fa036 
Signed-off-by: Astralidea <[email protected]>
@Astralidea
Fix UT.
266a430 
Signed-off-by: Astralidea <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 57 / 174 (32.76%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 0 3 00.00% [181, 182, 183]
🔵 com/starrocks/sql/analyzer/SemanticException.java 0 1 00.00% [72]
🔵 com/starrocks/server/GlobalStateMgr.java 0 27 00.00% [1570, 1571, 1580, 1581, 1582, 1583, 1584, 1585, 1586, 1588, 1589, 1590, 1591, 1592, 1593, 1594, 1596, 1597, 1598, 1599, 1600, 1601, 1602, 1604, 1605, 3302, 3303]
🔵 com/starrocks/persist/AlterMaterializedViewStatusLog.java 0 17 00.00% [38, 39, 40, 41, 42, 45, 49, 50, 53, 57, 58, 61, 65, 66, 70, 71, 74]
🔵 com/starrocks/persist/EditLog.java 0 6 00.00% [331, 332, 333, 334, 1639, 1640]
🔵 com/starrocks/journal/JournalEntity.java 0 3 00.00% [328, 329, 330]
🔵 com/starrocks/alter/AlterJobMgr.java 1 48 02.08% [319, 320, 321, 322, 324, 325, 326, 327, 328, 329, 330, 332, 334, 335, 337, 339, 340, 341, 353, 354, 355, 356, 357, 358, 360, 361, 363, 364, 365, 367, 368, 370, 371, 372, 373, 375, 376, 377, 379, 382, 383, 384, 385, 387, 388, 390, 392]
🔵 com/starrocks/sql/parser/AstBuilder.java 3 4 75.00% [1642]
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 48 60 80.00% [141, 142, 155, 157, 185, 186, 187, 188, 190, 876, 877, 878]
🔵 com/starrocks/sql/ast/AlterMaterializedViewStmt.java 5 5 100.00% []

@murphyatwork murphyatwork enabled auto-merge (squash) May 24, 2023 06:00
@murphyatwork murphyatwork merged commit f74e15e into StarRocks:main May 24, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label May 24, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label May 24, 2023
@mergify
Copy link
Contributor

mergify bot commented May 24, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 24, 2023
@Astralidea @mergify
[Enhancement] Support alter materialized view to active (#24001)
fb24cec 
Fixes #23304

---------

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit f74e15e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/Alter.java
#	fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/SemanticException.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/AlterMaterializedViewStmt.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocksLex.g4
#	test/sql/test_materialized_column/R/test_materialized_column
#	test/sql/test_mv/R/basic
@mergify mergify bot mentioned this pull request May 24, 2023
Closed
mergify bot pushed a commit that referenced this pull request May 24, 2023
@Astralidea @mergify
[Enhancement] Support alter materialized view to active (#24001)
c3c026c 
Fixes #23304

---------

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit f74e15e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/alter/Alter.java
#	fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/SemanticException.java
#	fe/fe-core/src/main/java/com/starrocks/sql/ast/AlterMaterializedViewStmt.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocksLex.g4
#	test/sql/test_materialized_column/R/test_materialized_column
#	test/sql/test_mv/R/basic
@mergify mergify bot mentioned this pull request May 24, 2023
Closed
This was referenced May 24, 2023
Merged
Merged
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request May 25, 2023
@Astralidea @wxl24life
[Enhancement] Support alter materialized view to active (StarRocks#24001
beb444c 
)

Fixes StarRocks#23304

---------

Signed-off-by: Astralidea <[email protected]>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@Astralidea @abc982627271
[Enhancement] Support alter materialized view to active (StarRocks#24001
26fdf28 
)

Fixes StarRocks#23304

---------

Signed-off-by: Astralidea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@packy92 packy92 packy92 approved these changes

Assignees

@Astralidea Astralidea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Astralidea @wanpengfei-git @murphyatwork @packy92