[BugFix] check time type in DDL (#23473) #23474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to check the time type when creating tables not in syntax file. |
packy92
reviewed
May 16, 2023
| @@ -2365,7 +2365,6 @@ baseType | |||
| | DOUBLE | |||
| | DATE | |||
| | DATETIME | |||
| | TIME | |||
| | CHAR typeParameter? | |||
There was a problem hiding this comment.
Now, cast(value as time) is supported. Maybe add check in DDL is better?
mysql> select cast(100 as time);
+-------------------+
| CAST(100 AS TIME) |
+-------------------+
| 00:01:00 |
+-------------------+
1 row in set (0.01 sec)
Problem: Time data type is not support in storage layer, it just a data type of parameter or return value for some function. It can not be specified by user in DDL Solution: check time type in DDL Signed-off-by: srlch <[email protected]>
srlch
force-pushed
the
remove_time_type_in_g4
branch
from
512c85a
to
0fc7fac
Compare
srlch
changed the title
have fix it |
|
Kudos, SonarCloud Quality Gate passed! |
trueeyu
approved these changes
May 16, 2023
Astralidea
approved these changes
May 16, 2023
packy92
reviewed
May 16, 2023
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableStatementAnalyzer.java
Show resolved
Hide resolved
[FE PR Coverage Check]😍 pass : 4 / 4 (100.00%) file detail
|
packy92
approved these changes
May 16, 2023
imay
reviewed
May 17, 2023
| @Test | ||
| public void testAlterWithTimeType() { | ||
| analyzeFail("alter table t0 add column testcol TIME"); | ||
| analyzeFail("alter table t0 modify column v0 TIME"); |
There was a problem hiding this comment.
Why not add a create table test case to cover creating table with TIME type.
There was a problem hiding this comment.
create table test case have existed in the code. We just miss for DDL
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL (cherry picked from commit e5b8a48) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableStatementAnalyzer.java # fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeAlterTableStatementTest.java
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL (cherry picked from commit e5b8a48) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AlterTableStatementAnalyzer.java # fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeAlterTableStatementTest.java
Moonm3n
pushed a commit
to Moonm3n/starrocks
that referenced
this pull request
May 23, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL Signed-off-by: Moonm3n <[email protected]>
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
Problem: The time data type is not supported in the storage layer, it is just a data type of parameter or return value for some function. It can not be specified by the user in DDL Solution: check time type in DDL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes:
Fixes #23473
Problem Summary(Required):
Problem:
Time data type is not support in storage layer, it just a data type of parameter or return value for some function.
It can not be specified by user in DDL
Solution:
check time type in DDL
Checklist:
Bugfix cherry-pick branch check: