[BugFix] fix schema change hang when data loading concurrent with schema change #23456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohaha
force-pushed
the
fix-schema-change-hang
branch
from
a90a99c
to
6908edd
Compare
sevev
previously approved these changes
May 16, 2023
…ema change Signed-off-by: luohaha <[email protected]>
luohaha
force-pushed
the
fix-schema-change-hang
branch
from
6908edd
to
d4c7f2a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
[FE PR Coverage Check]😍 pass : 3 / 3 (100.00%) file detail
|
trueeyu
approved these changes
May 18, 2023
sevev
approved these changes
May 18, 2023
chaoyli
approved these changes
May 18, 2023
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
|
@Mergifyio backport branch-2.4 |
✅ Backports have been created
|
|
@Mergifyio backport branch-2.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/task/AlterReplicaTask.java
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c)
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c)
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/task/AlterReplicaTask.java
wanpengfei-git
pushed a commit
that referenced
this pull request
May 22, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c)
wanpengfei-git
pushed a commit
that referenced
this pull request
May 22, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. (cherry picked from commit 084a19c)
Moonm3n
pushed a commit
to Moonm3n/starrocks
that referenced
this pull request
May 23, 2023
…ema change (StarRocks#23456) Fixes StarRocks#23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1. Signed-off-by: Moonm3n <[email protected]>
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
May 25, 2023
…ema change (StarRocks#23456) Fixes StarRocks#23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…ema change (StarRocks#23456) Fixes StarRocks#23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
luohaha
added a commit
to luohaha/starrocks
that referenced
this pull request
Jun 9, 2023
…ema change (StarRocks#23456) Fixes StarRocks#23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
luohaha
added a commit
to luohaha/starrocks
that referenced
this pull request
Jun 9, 2023
…ema change (StarRocks#23456) Fixes StarRocks#23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ema change (#23456) Fixes #23452 1. Assume there is a partition, current visible version is 13378, and all loading task is finished. 2. Trigger schema change, it will create new replica, and at the same time, one loading task is trigger and finished, and it's version is 13379. 3. Before send alter replica request, FE check that all loading task is finished, but loading task on new create replica haven't finish yet and V=1, LFV=13379. 4. Alter replica finish on BE, and BE send finish alter replica request back to FE. When call `handleFinishAlterTask`, `checkState` fail because LFV != -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes:
Fixes #23452
Problem Summary(Required):
handleFinishAlterTask,checkStatefail because LFV != -1.Checklist:
Bugfix cherry-pick branch check: