Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] The replication rules of CTAS are consistent with those of table crea… #22854

Merged
merged 2 commits into from
May 6, 2023
Merged

[Enhancement] The replication rules of CTAS are consistent with those of table crea… #22854

merged 2 commits into from
May 6, 2023

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented May 5, 2023 •
edited
Loading

…tion

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes:

Fixes #

Problem Summary(Required):

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@Astralidea
Fix UT.
940bbd9 
Signed-off-by: Astralidea <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/PropertyAnalyzer.java 1 1 100.00% []
🔵 com/starrocks/sql/analyzer/CTASAnalyzer.java 1 1 100.00% []

@Astralidea Astralidea enabled auto-merge (squash) May 6, 2023 02:33
@Astralidea Astralidea merged commit e3461e4 into StarRocks:main May 6, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label May 6, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented May 6, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label May 6, 2023
@mergify
Copy link
Contributor

mergify bot commented May 6, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 6, 2023
@Astralidea @mergify
[Enhancement] The replication rules of CTAS are consistent with those…
446f282 
… of table crea… (#22854)

* The replication rules of CTAS are consistent with those of table creation

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit e3461e4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CTASAnalyzer.java
@mergify mergify bot mentioned this pull request May 6, 2023
Closed
mergify bot pushed a commit that referenced this pull request May 6, 2023
@Astralidea @mergify
[Enhancement] The replication rules of CTAS are consistent with those…
91a8bf4 
… of table crea… (#22854)

* The replication rules of CTAS are consistent with those of table creation

Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit e3461e4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/util/PropertyAnalyzer.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CTASAnalyzer.java
@mergify mergify bot mentioned this pull request May 6, 2023
Closed
This was referenced May 6, 2023
Merged
Merged
@jaogoy
Copy link
Contributor

jaogoy commented May 6, 2023

@evelynzhaojie We need to add some notes in the document, such as:

  1. the default replication number of a table created by CTAS is the same to a normal table (default is 3), regardless of the replication number sof source tables.
  2. You can change the replication number in the PROPERTIES.

numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@Astralidea
[Enhancement] The replication rules of CTAS are consistent with those…
851e6a2 
… of table crea… (StarRocks#22854)

* The replication rules of CTAS are consistent with those of table creation

Signed-off-by: Astralidea <[email protected]>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@Astralidea @abc982627271
[Enhancement] The replication rules of CTAS are consistent with those…
2979b6e 
… of table crea… (StarRocks#22854)

* The replication rules of CTAS are consistent with those of table creation

Signed-off-by: Astralidea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@DorianZheng DorianZheng DorianZheng approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@Astralidea Astralidea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Astralidea @wanpengfei-git @jaogoy @wyb @DorianZheng @gengjun-git