Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the loss of bucket info after disable the dynamic partition #22595

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Apr 26, 2023

If user create table using dynamic partition with dynamic_partition.buckets. After they SET ('dynamic_partition.enable' = 'true') the buckets info is lost. The pull request fix this by eliminate the remove the buckets info

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/util/DynamicPartitionUtil.java 5 5 100.00% []

@Astralidea Astralidea merged commit edf164d into StarRocks:main Apr 27, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Apr 27, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2023

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Apr 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 27, 2023
…ion (#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info

(cherry picked from commit edf164d)
mergify bot pushed a commit that referenced this pull request Apr 27, 2023
…ion (#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info

(cherry picked from commit edf164d)
wanpengfei-git pushed a commit that referenced this pull request Apr 27, 2023
…ion (#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info

(cherry picked from commit edf164d)
@chaoyli
Copy link
Contributor Author

chaoyli commented Apr 27, 2023

The pull request in branch-2.5(#22672)

xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request May 10, 2023
…ion (StarRocks#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
…ion (StarRocks#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
…ion (StarRocks#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info
southernriver pushed a commit to southernriver/starrocks that referenced this pull request Nov 28, 2023
…ion (StarRocks#22595)

If user create table using dynamic partition with dynamic_partition.buckets.
After they `SET ('dynamic_partition.enable' = 'true')` the buckets info is lost.
The pull request fix this by eliminate the remove the buckets info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants