[Enhancement] Display inactive reason for materialized view #21591

murphyatwork · 2023-04-13T23:37:37Z

What type of PR is this：

Which issues of this PR fixes ：

Problem Summary(Required) ：

***************************[ 2. row ]***************************
MATERIALIZED_VIEW_ID                 | 90079
TABLE_SCHEMA                         | hehe
TABLE_NAME                           | mv_foo
REFRESH_TYPE                         | INCREMENTAL
IS_ACTIVE                            | false
INACTIVE_REASON                      | base table dropped: 10087
PARTITION_TYPE                       | UNPARTITIONED
TASK_ID                              |
TASK_NAME                            |
LAST_REFRESH_START_TIME              |
LAST_REFRESH_FINISHED_TIME           |
LAST_REFRESH_DURATION                |
LAST_REFRESH_STATE                   |
LAST_REFRESH_FORCE_REFRESH           |
LAST_REFRESH_START_PARTITION         |
LAST_REFRESH_END_PARTITION           |
LAST_REFRESH_BASE_REFRESH_PARTITIONS |
LAST_REFRESH_MV_REFRESH_PARTITIONS   |
LAST_REFRESH_ERROR_CODE              |
LAST_REFRESH_ERROR_MESSAGE           |
TABLE_ROWS                           | CREATE MATERIALIZED VIEW `mv_foo`
COMMENT "MATERIALIZED_VIEW"
DISTRIBUTED BY HASH(`id`) BUCKETS 2
REFRESH INCREMENTAL
PROPERTIES (
"replication_num" = "1",
"storage_medium" = "HDD"
)
AS SELECT `hehe`.`id`
FROM `hehe`.`hehe`;

Checklist:

I have added test cases for my bug fix or my new feature
This pr will affect users' behaviors
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

LiShuMing

Good Work~

ABingHuang · 2023-04-14T11:47:56Z

fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java

-                LOG.warn("Setting the materialized view {}({}) to invalid because " +
-                        "the table {} was renamed.", mv.getName(), mv.getId(), olapTable.getName());
-                mv.setActive(false);
+                mv.setInactiveAndReason("base table renamed: " + olapTable.getName());


better to keep the log

murphyatwork · 2023-05-17T14:05:45Z

@Mergifyio rebase

mergify · 2023-05-17T14:06:01Z

rebase

✅ Branch has been successfully rebased

murphyatwork · 2023-05-19T12:21:43Z

@Mergifyio rebase

Signed-off-by: Murphy <[email protected]>

mergify · 2023-05-19T12:22:09Z

rebase

✅ Branch has been successfully rebased

sonarcloud · 2023-05-19T12:30:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

0.0% Coverage
0.0% Duplication

wanpengfei-git · 2023-05-20T03:48:04Z

[FE PR Coverage Check]

😞 fail : 16 / 37 (43.24%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/service/FrontendServiceImpl.java	0	16	00.00%	[506, 507, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 521, 522, 524]
🔵	com/starrocks/server/GlobalStateMgr.java	0	2	00.00%	[1567, 1575]
🔵	com/starrocks/qe/ShowExecutor.java	1	2	50.00%	[567]
🔵	com/starrocks/catalog/MaterializedView.java	5	7	71.43%	[675, 1071]
🔵	com/starrocks/catalog/OlapTable.java	1	1	100.00%	[]
🔵	com/starrocks/catalog/system/information/MaterializedViewsSystemTable.java	1	1	100.00%	[]
🔵	com/starrocks/server/LocalMetastore.java	1	1	100.00%	[]
🔵	com/starrocks/alter/LakeTableSchemaChangeJob.java	3	3	100.00%	[]
🔵	com/starrocks/sql/ast/ShowMaterializedViewsStmt.java	1	1	100.00%	[]
🔵	com/starrocks/alter/SchemaChangeJobV2.java	3	3	100.00%	[]

Seaven · 2023-05-22T03:01:27Z

be/src/exec/schema_scanner/schema_materialized_views_scanner.cpp

+            // inactive_reason
+            ColumnPtr column = (*chunk)->get_column_by_slot_id(slot_id);
+            const std::string* str = &tbl_status.inactive_reason;
+            Slice value(str->c_str(), str->length());
+            fill_column_with_slot<TYPE_VARCHAR>(column.get(), (void*)&value);
+            break;
+        }
+        case 7: {


Will be compatibility questions with the BE upgrade?

wanpengfei-git · 2023-05-22T03:02:50Z

@Mergifyio backport branch-3.0

mergify · 2023-05-22T03:03:08Z

backport branch-3.0

✅ Backports have been created

#23818 [Enhancement] Display inactive reason for materialized view (backport #21591) has been created for branch branch-3.0 but encountered conflicts

(cherry picked from commit 7949502) # Conflicts: # be/src/exec/schema_scanner/schema_materialized_views_scanner.cpp # fe/fe-core/src/main/java/com/starrocks/catalog/system/information/MaterializedViewsSystemTable.java # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java # fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java

…s#21591) Signed-off-by: Moonm3n <[email protected]>

…s#21591)

murphyatwork enabled auto-merge (squash) April 13, 2023 23:37

github-actions bot added the 3.0 label Apr 13, 2023

mergify bot assigned murphyatwork Apr 13, 2023

LiShuMing previously approved these changes Apr 14, 2023

View reviewed changes

murphyatwork dismissed LiShuMing’s stale review via e30a29e April 14, 2023 04:38

ABingHuang reviewed Apr 14, 2023

View reviewed changes

Astralidea mentioned this pull request May 12, 2023

[Enhancement] Support alter materialized view to active #23304

Closed

16 tasks

murphyatwork force-pushed the murphy_mv_inactive_reason branch from 45a69e1 to 1dd866f Compare May 17, 2023 07:32

murphyatwork added the sig/materialized view label May 17, 2023

Astralidea previously approved these changes May 17, 2023

View reviewed changes

murphyatwork force-pushed the murphy_mv_inactive_reason branch from 1dd866f to b19781c Compare May 17, 2023 14:06

murphyatwork dismissed Astralidea’s stale review via 6406c68 May 18, 2023 06:54

murphyatwork force-pushed the murphy_mv_inactive_reason branch from b19781c to 6406c68 Compare May 18, 2023 06:54

Astralidea previously approved these changes May 18, 2023

View reviewed changes

murphyatwork dismissed Astralidea’s stale review via 2eef791 May 19, 2023 08:47

murphyatwork added 12 commits May 19, 2023 12:22

display inactive reason for MV

13ec2b3

Signed-off-by: Murphy <[email protected]>

implement in be

9701453

fe

f472425

Signed-off-by: Murphy <[email protected]>

fe

9281632

Signed-off-by: Murphy <[email protected]>

fix

0f69d51

Signed-off-by: Murphy <[email protected]>

b

391a49a

test case

0d654fc

fix

07901e4

Signed-off-by: Murphy <[email protected]>

fix test

e8949e8

Signed-off-by: Murphy <[email protected]>

fix test

1497e67

keep log

4a6f8a6

Signed-off-by: Murphy <[email protected]>

fix schema

a2ee96b

Signed-off-by: Murphy <[email protected]>

murphyatwork force-pushed the murphy_mv_inactive_reason branch from 2eef791 to a2ee96b Compare May 19, 2023 12:22

Astralidea approved these changes May 22, 2023

View reviewed changes

Seaven reviewed May 22, 2023

View reviewed changes

satanson approved these changes May 22, 2023

View reviewed changes

murphyatwork merged commit 7949502 into StarRocks:main May 22, 2023

github-actions bot removed the 3.0 label May 22, 2023

mergify bot mentioned this pull request May 22, 2023

[Enhancement] Display inactive reason for materialized view (backport #21591) #23818

Closed

Moonm3n pushed a commit to Moonm3n/starrocks that referenced this pull request May 23, 2023

[Enhancement] Display inactive reason for materialized view (StarRock…

4c3b5cb

…s#21591) Signed-off-by: Moonm3n <[email protected]>

wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request May 25, 2023

[Enhancement] Display inactive reason for materialized view (StarRock…

21221a4

…s#21591)

abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023

[Enhancement] Display inactive reason for materialized view (StarRock…

29564d3

…s#21591)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Display inactive reason for materialized view #21591

[Enhancement] Display inactive reason for materialized view #21591

murphyatwork commented Apr 13, 2023

LiShuMing left a comment

ABingHuang Apr 14, 2023

murphyatwork May 17, 2023

murphyatwork commented May 17, 2023

mergify bot commented May 17, 2023

murphyatwork commented May 19, 2023

mergify bot commented May 19, 2023

sonarcloud bot commented May 19, 2023

wanpengfei-git commented May 20, 2023

Seaven May 22, 2023 •

edited

Loading

wanpengfei-git commented May 22, 2023

mergify bot commented May 22, 2023 •

edited

Loading

[Enhancement] Display inactive reason for materialized view #21591

[Enhancement] Display inactive reason for materialized view #21591

Conversation

murphyatwork commented Apr 13, 2023

What type of PR is this：

Which issues of this PR fixes ：

Problem Summary(Required) ：

Checklist:

Bugfix cherry-pick branch check:

LiShuMing left a comment

Choose a reason for hiding this comment

ABingHuang Apr 14, 2023

Choose a reason for hiding this comment

murphyatwork May 17, 2023

Choose a reason for hiding this comment

murphyatwork commented May 17, 2023

mergify bot commented May 17, 2023

✅ Branch has been successfully rebased

murphyatwork commented May 19, 2023

mergify bot commented May 19, 2023

✅ Branch has been successfully rebased

sonarcloud bot commented May 19, 2023

wanpengfei-git commented May 20, 2023

[FE PR Coverage Check]

file detail

Seaven May 22, 2023 • edited Loading

Choose a reason for hiding this comment

wanpengfei-git commented May 22, 2023

mergify bot commented May 22, 2023 • edited Loading

✅ Backports have been created

Seaven May 22, 2023 •

edited

Loading

mergify bot commented May 22, 2023 •

edited

Loading