-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Cancel fragment instance not query when close external scanner #20264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
silverbullet233
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
satanson
approved these changes
Mar 27, 2023
Astralidea
approved these changes
Mar 27, 2023
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
…er (#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]> (cherry picked from commit 907dd9d)
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
…er (#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]> (cherry picked from commit 907dd9d)
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 27, 2023
…er (#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]> (cherry picked from commit 907dd9d)
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 27, 2023
…er (#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]> (cherry picked from commit 907dd9d)
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
…er (StarRocks#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]>
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…er (StarRocks#20264) * [BugFix] cancel fragment instance not query when close external scanner If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE. Query executed by external connectors does not need to report exec state to FE. Signed-off-by: wyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #
Problem Summary(Required) :
If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE.
Query executed by external connectors does not need to report exec state
to FE.
Checklist:
Bugfix cherry-pick branch check: