Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Cancel fragment instance not query when close external scanner #20264

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Mar 24, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

If cancel query, other fragment instances (scanners) will be cancelled, and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Signed-off-by: wyb <[email protected]>
Copy link
Contributor

@silverbullet233 silverbullet233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satanson satanson enabled auto-merge (squash) March 27, 2023 02:12
@satanson satanson merged commit 907dd9d into StarRocks:main Mar 27, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Mar 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 27, 2023
…er (#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 907dd9d)
mergify bot pushed a commit that referenced this pull request Mar 27, 2023
…er (#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 907dd9d)
wanpengfei-git pushed a commit that referenced this pull request Mar 27, 2023
…er (#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 907dd9d)
wanpengfei-git pushed a commit that referenced this pull request Mar 27, 2023
…er (#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
(cherry picked from commit 907dd9d)
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
…er (StarRocks#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
…er (StarRocks#20264)

* [BugFix] cancel fragment instance not query when close external scanner

If cancel query, other fragment instances (scanners) will be cancelled,
and spark connector will report SocketTimeoutException when get next data from BE.

Query executed by external connectors does not need to report exec state
to FE.

Signed-off-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants