[BugFix] Be maybe crash when we do schema change for primary key table with separate primary key and sort key #20035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangqiang <[email protected]>
Signed-off-by: zhangqiang <[email protected]>
chaoyli
reviewed
Mar 22, 2023
Signed-off-by: zhangqiang <[email protected]>
|
Signed-off-by: zhangqiang <[email protected]>
Signed-off-by: zhangqiang <[email protected]>
done, fixed. |
decster
previously approved these changes
Mar 23, 2023
Signed-off-by: zhangqiang <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
chaoyli
approved these changes
Mar 28, 2023
decster
approved these changes
Mar 28, 2023
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…e with separate primary key and sort key (#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]> (cherry picked from commit 82f9d31)
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…e with separate primary key and sort key (#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]> (cherry picked from commit 82f9d31)
wanpengfei-git
pushed a commit
that referenced
this pull request
Mar 29, 2023
…e with separate primary key and sort key (#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]> (cherry picked from commit 82f9d31)
numbernumberone
pushed a commit
to numbernumberone/starrocks
that referenced
this pull request
May 31, 2023
…e with separate primary key and sort key (StarRocks#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(StarRocks#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]>
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…e with separate primary key and sort key (StarRocks#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(StarRocks#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]>
sevev
added a commit
to sevev/starrocks
that referenced
this pull request
Dec 7, 2023
…e with separate primary key and sort key (StarRocks#20035) If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column) The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(StarRocks#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash. Signed-off-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 8, 2023
…ange for primary key table with separate primary key and sort key (#20035) (#36636) Signed-off-by: zhangqiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
If we create a primary key table with a separate primary key and sort key, BE maybe crash if we do a schema change in the table(add column/drop column)
The reason is that we use column id as the sort key index in the tablet, and we only support reordering the sort key in this pr(#13642) which assumes the number of columns in the origin tablet and new tablet during schema change is the same. However, if we add/drop a column, the sort key index in the new tablet will be different from the origin tablet and we will execute reorder which may cause BE crash.
Checklist:
Bugfix cherry-pick branch check: