Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] make mv preprocess more robust #19551

Merged
merged 2 commits into from
Mar 16, 2023
Merged

[Enhancement] make mv preprocess more robust #19551

merged 2 commits into from
Mar 16, 2023

Conversation

ABingHuang
Copy link
Contributor

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #19549

Problem Summary(Required) ：

make mv preprocess more robust to exception. skip the failed mv during preprocess.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@ABingHuang ABingHuang changed the title make mv preprocess more robust [Enhancement] make mv preprocess more robust Mar 15, 2023
@ABingHuang
fix ut
02aff8a 
Signed-off-by: ABingHuang <[email protected]>
@github-actions github-actions bot removed the be-build label Mar 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 44 / 57 (77.19%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 1 8 12.50% [919, 920, 921, 1018, 1019, 1020, 1021]
🔵 com/starrocks/sql/optimizer/MvRewritePreprocessor.java 43 49 87.76% [85, 86, 87, 94, 105, 128]

@murphyatwork murphyatwork enabled auto-merge (squash) March 15, 2023 18:50
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Mar 16, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

3 similar comments
@ABingHuang
Copy link
Contributor Author

run starrocks_admit_test

@ABingHuang
Copy link
Contributor Author

run starrocks_admit_test

@ABingHuang
Copy link
Contributor Author

run starrocks_admit_test

@murphyatwork murphyatwork merged commit 39ffce1 into StarRocks:main Mar 16, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Mar 16, 2023
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Mar 19, 2023
@ABingHuang @Jay-ju
[Enhancement] make mv preprocess more robust (StarRocks#19551)
6f5fda5
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Mar 20, 2023
@ABingHuang
[Enhancement] make mv preprocess more robust (StarRocks#19551)
e287ae8 
Signed-off-by: ABingHuang <[email protected]>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Mar 20, 2023
@ABingHuang
[Enhancement] make mv preprocess more robust (StarRocks#19551)
2da4fce 
Signed-off-by: ABingHuang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 20, 2023
@ABingHuang @wanpengfei-git
[Enhancement] make mv preprocess more robust (#19551)
0207b5c 
Signed-off-by: ABingHuang <[email protected]>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Mar 22, 2023
@ABingHuang
[Enhancement] make mv preprocess more robust (StarRocks#19551)
756788a 
Signed-off-by: ABingHuang <[email protected]>
wanpengfei-git pushed a commit to ABingHuang/starrocks that referenced this pull request Mar 22, 2023
@ABingHuang @wanpengfei-git
[Enhancement] make mv preprocess more robust (StarRocks#19551)
125cf94 
Signed-off-by: ABingHuang <[email protected]>
wanpengfei-git pushed a commit to ABingHuang/starrocks that referenced this pull request Mar 22, 2023
@ABingHuang @wanpengfei-git
[Enhancement] make mv preprocess more robust (StarRocks#19551)
06ae2c2 
Signed-off-by: ABingHuang <[email protected]>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Mar 23, 2023
@ABingHuang
[Enhancement] make mv preprocess more robust (StarRocks#19551)
75cdc08 
Signed-off-by: ABingHuang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 23, 2023
@ABingHuang @wanpengfei-git
[Enhancement] make mv preprocess more robust (#19551)
7bea426 
Signed-off-by: ABingHuang <[email protected]>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@ABingHuang
[Enhancement] make mv preprocess more robust (StarRocks#19551)
7c0c0b6
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@ABingHuang @abc982627271
[Enhancement] make mv preprocess more robust (StarRocks#19551)
6e2dde5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youngwb Youngwb Youngwb approved these changes

@murphyatwork murphyatwork murphyatwork approved these changes

Assignees

@ABingHuang ABingHuang

Labels
sig/materialized view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make mv rewrite preprocess more robust
4 participants
@ABingHuang @wanpengfei-git @Youngwb @murphyatwork