fix to assign wrong nullable property to dict column #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
approved these changes
Dec 2, 2021
laotan332
approved these changes
Dec 2, 2021
stdpain
approved these changes
Dec 2, 2021
Youngwb
approved these changes
Dec 2, 2021
dirtysalt
added a commit
that referenced
this pull request
Dec 2, 2021
caneGuy
pushed a commit
to caneGuy/starrocks
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1690
When generating plan fragment on dict decode node, the nullable property of dict column is always set to true, which is wrong.
We have to use the same value of nullable property of dict code column. The nullable property should be consistent always.