-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] create new functions such as current_timestamp, current_date #14319
Conversation
…amp funcation like spark and presto
spark and presto can execute but starrocks only execute such as so enhance functions like spark and presto, now we can execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better add UT
run starrocks_fe_unittest |
run starrocks_admit_test |
| name = LOCALTIME ('(' ')')? | ||
| name = LOCALTIMESTAMP ('(' ')')? | ||
; | ||
|
||
specialFunctionExpression | ||
: CHAR '(' expression ')' | ||
| CURRENT_TIMESTAMP '(' ')' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can unify CURRENT_TIMESTAMP and specialDateTimeExpression together
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 3 / 3 (100.00%) file detail
|
run starrocks_admit_test |
@Mergifyio backport branch-2.5 |
#14319) * add current_timestamp,current_time,current_date,localtime,localtimestamp funcation like spark and presto * remove key word CURRENT_DATE CURRENT_TIME CURRENT_TIMESTAMP LOCALTIME LOCALTIMESTAMP * add select time fun ut * add one assertion to localtimestamp * unify CURRENT_TIMESTAMP and specialDateTimeExpression together (cherry picked from commit b4f413e)
✅ Backports have been created
|
#14319) * add current_timestamp,current_time,current_date,localtime,localtimestamp funcation like spark and presto * remove key word CURRENT_DATE CURRENT_TIME CURRENT_TIMESTAMP LOCALTIME LOCALTIMESTAMP * add select time fun ut * add one assertion to localtimestamp * unify CURRENT_TIMESTAMP and specialDateTimeExpression together (cherry picked from commit b4f413e)
…amp funcation
like spark and presto
What type of PR is this:
Which issues of this PR fixes :
Fixes
#15382
#15285
Problem Summary(Required) :
Checklist:
Bugfix cherry-pick branch check: