[Feature] Support bitwise shift functions #14151

sparklezzz · 2022-11-26T08:22:37Z

What type of PR is this：

Which issues of this PR fixes ：

Problem Summary(Required) ：

NEW FUNCTIONS:

BIT_SHIFT_LEFT(value, shift): perform bitwise left shift.
BIT_SHIFT_RIGHT(value, shift): perform bitwise right shift arithmetic.
BIT_SHIFT_RIGHT_LOGICAL(value, shift): perform bitwise right shift logical.

In above three functions, the type of first operator is within TINYINT, SMALLINT, INT, BIGINT, LARGEINT, and the type of second operator is BIGINT.

Test sql:

CREATE TABLE IF NOT EXISTS `shift_test` (
  `c1` TINYINT,
  `c2` SMALLINT,
  `c3` INT,
  `c4` BIGINT,
  `c5` LARGEINT
)
ENGINE = OLAP
DUPLICATE KEY(`c1`)
DISTRIBUTED BY HASH(`c1`) BUCKETS 1
PROPERTIES (
  "replication_num" = "1" 
)
;

INSERT INTO `shift_test` VALUES (11, 2222, 33333333, 444444444, 5555555555555);
INSERT INTO `shift_test` VALUES (-11, -2222, -33333333, -444444444, -5555555555555);

SELECT BIT_SHIFT_LEFT(11, 3),  BIT_SHIFT_LEFT(2222, 3),  BIT_SHIFT_LEFT(33333333, 3),  BIT_SHIFT_LEFT(444444444, 3),  BIT_SHIFT_LEFT(5555555555555, 3);
SELECT BIT_SHIFT_LEFT(-11, 3),  BIT_SHIFT_LEFT(-2222, 3),  BIT_SHIFT_LEFT(-33333333, 3),  BIT_SHIFT_LEFT(-444444444, 3),  BIT_SHIFT_LEFT(-5555555555555, 3);

SELECT BIT_SHIFT_RIGHT(11, 3),  BIT_SHIFT_RIGHT(2222, 3),  BIT_SHIFT_RIGHT(33333333, 3),  BIT_SHIFT_RIGHT(444444444, 3),  BIT_SHIFT_RIGHT(5555555555555, 3);
SELECT BIT_SHIFT_RIGHT(-11, 3),  BIT_SHIFT_RIGHT(-2222, 3),  BIT_SHIFT_RIGHT(-33333333, 3),  BIT_SHIFT_RIGHT(-444444444, 3),  BIT_SHIFT_RIGHT(-5555555555555, 3);

SELECT BIT_SHIFT_RIGHT_LOGICAL(11, 3),  BIT_SHIFT_RIGHT_LOGICAL(2222, 3),  BIT_SHIFT_RIGHT_LOGICAL(33333333, 3),  BIT_SHIFT_RIGHT_LOGICAL(444444444, 3),  BIT_SHIFT_RIGHT_LOGICAL(5555555555555, 3);
SELECT BIT_SHIFT_RIGHT_LOGICAL(-11, 3),  BIT_SHIFT_RIGHT_LOGICAL(-2222, 3),  BIT_SHIFT_RIGHT_LOGICAL(-33333333, 3),  BIT_SHIFT_RIGHT_LOGICAL(-444444444, 3),  BIT_SHIFT_RIGHT_LOGICAL(-5555555555555, 3);


SELECT `c1`, BIT_SHIFT_LEFT(`c1`, 3) FROM `shift_test`;
SELECT `c1`, BIT_SHIFT_RIGHT(`c1`, 3) FROM `shift_test`;
SELECT `c1`, BIT_SHIFT_RIGHT_LOGICAL(`c1`, 3) FROM `shift_test`;

SELECT `c2`, BIT_SHIFT_LEFT(`c2`, 3) FROM `shift_test`;
SELECT `c2`, BIT_SHIFT_RIGHT(`c2`, 3) FROM `shift_test`;
SELECT `c2`, BIT_SHIFT_RIGHT_LOGICAL(`c2`, 3) FROM `shift_test`;

SELECT `c3`, BIT_SHIFT_LEFT(`c3`, 3) FROM `shift_test`;
SELECT `c3`, BIT_SHIFT_RIGHT(`c3`, 3) FROM `shift_test`;
SELECT `c3`, BIT_SHIFT_RIGHT_LOGICAL(`c3`, 3) FROM `shift_test`;

SELECT `c4`, BIT_SHIFT_LEFT(`c4`, 3) FROM `shift_test`;
SELECT `c4`, BIT_SHIFT_RIGHT(`c4`, 3) FROM `shift_test`;
SELECT `c4`, BIT_SHIFT_RIGHT_LOGICAL(`c4`, 3) FROM `shift_test`;

SELECT `c5`, BIT_SHIFT_LEFT(`c5`, 3) FROM `shift_test`;
SELECT `c5`, BIT_SHIFT_RIGHT(`c5`, 3) FROM `shift_test`;
SELECT `c5`, BIT_SHIFT_RIGHT_LOGICAL(`c5`, 3) FROM `shift_test`;

SELECT BIT_SHIFT_LEFT(`c1`, `c1`), BIT_SHIFT_LEFT(`c2`, `c1`), BIT_SHIFT_LEFT(`c3`, `c1`), BIT_SHIFT_LEFT(`c4`, `c1`), BIT_SHIFT_LEFT(`c5`, `c1`) FROM `shift_test`;

SELECT BIT_SHIFT_RIGHT(`c1`, `c1`), BIT_SHIFT_RIGHT(`c2`, `c1`), BIT_SHIFT_RIGHT(`c3`, `c1`), BIT_SHIFT_RIGHT(`c4`, `c1`), BIT_SHIFT_RIGHT(`c5`, `c1`) FROM `shift_test`;

SELECT BIT_SHIFT_RIGHT_LOGICAL(`c1`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c2`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c3`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c4`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c5`, `c1`) FROM `shift_test`;

Checklist:

I have added test cases for my bug fix or my new feature
This pr will affect users' behaviors
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

CLAassistant · 2022-11-26T08:22:41Z

All committers have signed the CLA.

murphyatwork · 2022-11-26T14:26:52Z

Please rebase the code with branch main, recently we have applied some refactor over the PrimitiveType.

github-actions

clang-tidy made some suggestions

github-actions · 2022-12-01T16:40:19Z

be/src/exec/pipeline/scan/lake_meta_scan_prepare_operator.cpp

@@ -0,0 +1,44 @@
+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+
+#include "exec/pipeline/scan/lake_meta_scan_prepare_operator.h"


warning: 'exec/pipeline/scan/lake_meta_scan_prepare_operator.h' file not found [clang-diagnostic-error]

#include "exec/pipeline/scan/lake_meta_scan_prepare_operator.h" ^

github-actions · 2022-12-01T16:40:19Z

be/src/exec/pipeline/scan/lake_meta_scan_prepare_operator.h

+
+#pragma once
+
+#include "exec/pipeline/scan/meta_scan_context.h"


warning: 'exec/pipeline/scan/meta_scan_context.h' file not found [clang-diagnostic-error]

#include "exec/pipeline/scan/meta_scan_context.h" ^

github-actions · 2022-12-01T16:40:20Z

be/src/exec/pipeline/scan/meta_scan_operator.cpp

@@ -0,0 +1,89 @@
+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+
+#include "exec/pipeline/scan/meta_scan_operator.h"


warning: 'exec/pipeline/scan/meta_scan_operator.h' file not found [clang-diagnostic-error]

#include "exec/pipeline/scan/meta_scan_operator.h" ^

github-actions · 2022-12-01T16:40:20Z

be/src/exec/pipeline/scan/meta_scan_operator.h

+
+#pragma once
+
+#include "exec/pipeline/pipeline_builder.h"


warning: 'exec/pipeline/pipeline_builder.h' file not found [clang-diagnostic-error]

#include "exec/pipeline/pipeline_builder.h" ^

github-actions · 2022-12-01T16:40:20Z

be/src/exec/pipeline/scan/meta_scan_prepare_operator.cpp

@@ -0,0 +1,54 @@
+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+
+#include "exec/pipeline/scan/meta_scan_prepare_operator.h"


warning: 'exec/pipeline/scan/meta_scan_prepare_operator.h' file not found [clang-diagnostic-error]

#include "exec/pipeline/scan/meta_scan_prepare_operator.h" ^

github-actions · 2022-12-01T16:40:23Z

be/src/runtime/lake_tablets_channel.cpp

+          _mem_tracker(mem_tracker),
+          _mem_pool(std::make_unique<MemPool>()) {}
+
+LakeTabletsChannel::~LakeTabletsChannel() {


warning: use '= default' to define a trivial destructor [modernize-use-equals-default]

LakeTabletsChannel::~LakeTabletsChannel() { ^

github-actions · 2022-12-01T16:40:24Z

be/src/storage/lake_meta_reader.cpp

@@ -0,0 +1,159 @@
+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+
+#include "storage/lake_meta_reader.h"


warning: 'storage/lake_meta_reader.h' file not found [clang-diagnostic-error]

#include "storage/lake_meta_reader.h" ^

github-actions · 2022-12-01T16:40:24Z

be/src/storage/lake_meta_reader.h

+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+#pragma once
+
+#include <string>


warning: 'string' file not found [clang-diagnostic-error]

#include <string> ^

github-actions · 2022-12-01T16:40:24Z

be/src/storage/olap_meta_reader.cpp

@@ -0,0 +1,179 @@
+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+
+#include "storage/olap_meta_reader.h"


warning: 'storage/olap_meta_reader.h' file not found [clang-diagnostic-error]

#include "storage/olap_meta_reader.h" ^

github-actions · 2022-12-01T16:40:24Z

be/src/storage/olap_meta_reader.h

+// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.
+#pragma once
+
+#include <string>


warning: 'string' file not found [clang-diagnostic-error]

#include <string> ^

github-actions · 2022-12-02T14:02:50Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2022-12-02T17:57:59Z

clang-tidy review says "All clean, LGTM! 👍"

…gical function

…ical function

…gical function

github-actions · 2022-12-03T02:52:22Z

clang-tidy review says "All clean, LGTM! 👍"

…gical function

wanpengfei-git · 2022-12-03T07:47:35Z

[FE PR Coverage Check]

😍 pass : 65 / 65 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/parser/AstBuilder.java	3	3	100.00%	[]
🔵	com/starrocks/analysis/ArithmeticExpr.java	16	16	100.00%	[]
🔵	com/starrocks/sql/plan/ScalarOperatorToExpr.java	12	12	100.00%	[]
🔵	com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java	32	32	100.00%	[]
🔵	com/starrocks/sql/analyzer/ExpressionAnalyzer.java	2	2	100.00%	[]

github-actions · 2022-12-03T08:23:28Z

clang-tidy review says "All clean, LGTM! 👍"

sonarcloud · 2022-12-03T08:24:08Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
9.0% Duplication

murphyatwork · 2022-12-03T08:31:42Z

run starrocks_admit_test

sonarcloud · 2022-12-03T08:42:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

wanpengfei-git · 2022-12-06T22:53:47Z

run starrocks_admit_test

kateshaowanjou · 2022-12-07T04:00:47Z

Congratulations on your first merged PR to StarRocks! 🎉 @sparklezzz

NEW FUNCTIONS: 1. `BIT_SHIFT_LEFT(value, shift)`: perform bitwise left shift. 2. `BIT_SHIFT_RIGHT(value, shift)`: perform bitwise right shift arithmetic. 3. `BIT_SHIFT_RIGHT_LOGICAL(value, shift)`: perform bitwise right shift logical. In above three functions, the type of first operator is within TINYINT, SMALLINT, INT, BIGINT, LARGEINT, and the type of second operator is BIGINT. Test sql: ```sql CREATE TABLE IF NOT EXISTS `shift_test` ( `c1` TINYINT, `c2` SMALLINT, `c3` INT, `c4` BIGINT, `c5` LARGEINT ) ENGINE = OLAP DUPLICATE KEY(`c1`) DISTRIBUTED BY HASH(`c1`) BUCKETS 1 PROPERTIES ( "replication_num" = "1" ) ; INSERT INTO `shift_test` VALUES (11, 2222, 33333333, 444444444, 5555555555555); INSERT INTO `shift_test` VALUES (-11, -2222, -33333333, -444444444, -5555555555555); SELECT BIT_SHIFT_LEFT(11, 3), BIT_SHIFT_LEFT(2222, 3), BIT_SHIFT_LEFT(33333333, 3), BIT_SHIFT_LEFT(444444444, 3), BIT_SHIFT_LEFT(5555555555555, 3); SELECT BIT_SHIFT_LEFT(-11, 3), BIT_SHIFT_LEFT(-2222, 3), BIT_SHIFT_LEFT(-33333333, 3), BIT_SHIFT_LEFT(-444444444, 3), BIT_SHIFT_LEFT(-5555555555555, 3); SELECT BIT_SHIFT_RIGHT(11, 3), BIT_SHIFT_RIGHT(2222, 3), BIT_SHIFT_RIGHT(33333333, 3), BIT_SHIFT_RIGHT(444444444, 3), BIT_SHIFT_RIGHT(5555555555555, 3); SELECT BIT_SHIFT_RIGHT(-11, 3), BIT_SHIFT_RIGHT(-2222, 3), BIT_SHIFT_RIGHT(-33333333, 3), BIT_SHIFT_RIGHT(-444444444, 3), BIT_SHIFT_RIGHT(-5555555555555, 3); SELECT BIT_SHIFT_RIGHT_LOGICAL(11, 3), BIT_SHIFT_RIGHT_LOGICAL(2222, 3), BIT_SHIFT_RIGHT_LOGICAL(33333333, 3), BIT_SHIFT_RIGHT_LOGICAL(444444444, 3), BIT_SHIFT_RIGHT_LOGICAL(5555555555555, 3); SELECT BIT_SHIFT_RIGHT_LOGICAL(-11, 3), BIT_SHIFT_RIGHT_LOGICAL(-2222, 3), BIT_SHIFT_RIGHT_LOGICAL(-33333333, 3), BIT_SHIFT_RIGHT_LOGICAL(-444444444, 3), BIT_SHIFT_RIGHT_LOGICAL(-5555555555555, 3); SELECT `c1`, BIT_SHIFT_LEFT(`c1`, 3) FROM `shift_test`; SELECT `c1`, BIT_SHIFT_RIGHT(`c1`, 3) FROM `shift_test`; SELECT `c1`, BIT_SHIFT_RIGHT_LOGICAL(`c1`, 3) FROM `shift_test`; SELECT `c2`, BIT_SHIFT_LEFT(`c2`, 3) FROM `shift_test`; SELECT `c2`, BIT_SHIFT_RIGHT(`c2`, 3) FROM `shift_test`; SELECT `c2`, BIT_SHIFT_RIGHT_LOGICAL(`c2`, 3) FROM `shift_test`; SELECT `c3`, BIT_SHIFT_LEFT(`c3`, 3) FROM `shift_test`; SELECT `c3`, BIT_SHIFT_RIGHT(`c3`, 3) FROM `shift_test`; SELECT `c3`, BIT_SHIFT_RIGHT_LOGICAL(`c3`, 3) FROM `shift_test`; SELECT `c4`, BIT_SHIFT_LEFT(`c4`, 3) FROM `shift_test`; SELECT `c4`, BIT_SHIFT_RIGHT(`c4`, 3) FROM `shift_test`; SELECT `c4`, BIT_SHIFT_RIGHT_LOGICAL(`c4`, 3) FROM `shift_test`; SELECT `c5`, BIT_SHIFT_LEFT(`c5`, 3) FROM `shift_test`; SELECT `c5`, BIT_SHIFT_RIGHT(`c5`, 3) FROM `shift_test`; SELECT `c5`, BIT_SHIFT_RIGHT_LOGICAL(`c5`, 3) FROM `shift_test`; SELECT BIT_SHIFT_LEFT(`c1`, `c1`), BIT_SHIFT_LEFT(`c2`, `c1`), BIT_SHIFT_LEFT(`c3`, `c1`), BIT_SHIFT_LEFT(`c4`, `c1`), BIT_SHIFT_LEFT(`c5`, `c1`) FROM `shift_test`; SELECT BIT_SHIFT_RIGHT(`c1`, `c1`), BIT_SHIFT_RIGHT(`c2`, `c1`), BIT_SHIFT_RIGHT(`c3`, `c1`), BIT_SHIFT_RIGHT(`c4`, `c1`), BIT_SHIFT_RIGHT(`c5`, `c1`) FROM `shift_test`; SELECT BIT_SHIFT_RIGHT_LOGICAL(`c1`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c2`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c3`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c4`, `c1`), BIT_SHIFT_RIGHT_LOGICAL(`c5`, `c1`) FROM `shift_test`; ```

github-actions bot added the title needs [type] label Nov 26, 2022

sparklezzz changed the title ~~Feature bit shift op~~ [Feature] Support bitwise shift functions Nov 26, 2022

github-actions bot removed the title needs [type] label Nov 26, 2022

stdpain previously approved these changes Nov 30, 2022

View reviewed changes

sparklezzz dismissed stdpain’s stale review via cd0df57 December 1, 2022 15:42

wanpengfei-git added the be-build label Dec 1, 2022

github-actions bot reviewed Dec 1, 2022

View reviewed changes

sparklezzz force-pushed the feature-bit-shift-op branch from 874723f to a8ed04d Compare December 2, 2022 13:08

github-actions bot removed the be-build label Dec 2, 2022

wanpengfei-git added the be-build label Dec 2, 2022

github-actions bot removed the be-build label Dec 2, 2022

wanpengfei-git added the be-build label Dec 2, 2022

github-actions bot removed the be-build label Dec 3, 2022

xudong.zhang and others added 6 commits December 3, 2022 10:07

feat(function): support bit shift left; bit shift right; bit shift lo…

5ff9407

…gical function

fix(function): support bit shift left; bit shift right; bit shift log…

1d7b9eb

…ical function

fix(function): support bit shift left; bit shift right; bit shift log…

44000d9

…ical function

fix(function): support bit shift left; bit shift right; bit shift log…

5f3857b

…ical function

fix(function): support bit shift left; bit shift right; bit shift log…

a98f494

…ical function

test(function): support bit shift left; bit shift right; bit shift lo…

e5280aa

…gical function

sparklezzz force-pushed the feature-bit-shift-op branch from 79860ea to e5280aa Compare December 3, 2022 02:08

wanpengfei-git added the be-build label Dec 3, 2022

test(function): support bit shift left; bit shift right; bit shift lo…

6cf80a8

…gical function

github-actions bot removed the be-build label Dec 3, 2022

test(function): support bit shift left; bit shift right; bit shift lo…

a86438a

…gical function

wanpengfei-git added the be-build label Dec 3, 2022

murphyatwork requested review from murphyatwork, Astralidea and liuyehcf December 3, 2022 08:32

murphyatwork self-assigned this Dec 3, 2022

murphyatwork approved these changes Dec 3, 2022

View reviewed changes

imay approved these changes Dec 6, 2022

View reviewed changes

wanpengfei-git added the Approved Ready to merge label Dec 6, 2022

imay merged commit 58511ea into StarRocks:main Dec 6, 2022

github-actions bot removed the Approved Ready to merge label Dec 6, 2022

github-actions bot removed the be-build label Dec 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Support bitwise shift functions #14151

[Feature] Support bitwise shift functions #14151

sparklezzz commented Nov 26, 2022 •

edited by wangsimo0

Loading

CLAassistant commented Nov 26, 2022 •

edited

Loading

murphyatwork commented Nov 26, 2022

github-actions bot left a comment

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot Dec 1, 2022

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 3, 2022

wanpengfei-git commented Dec 3, 2022

github-actions bot commented Dec 3, 2022

sonarcloud bot commented Dec 3, 2022

murphyatwork commented Dec 3, 2022

sonarcloud bot commented Dec 3, 2022

wanpengfei-git commented Dec 6, 2022

kateshaowanjou commented Dec 7, 2022

		@@ -0,0 +1,44 @@
		// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.

		#include "exec/pipeline/scan/lake_meta_scan_prepare_operator.h"


		#pragma once

		#include "exec/pipeline/scan/meta_scan_context.h"

		@@ -0,0 +1,89 @@
		// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.

		#include "exec/pipeline/scan/meta_scan_operator.h"

		@@ -0,0 +1,54 @@
		// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.

		#include "exec/pipeline/scan/meta_scan_prepare_operator.h"

		@@ -0,0 +1,159 @@
		// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.

		#include "storage/lake_meta_reader.h"

		@@ -0,0 +1,179 @@
		// This file is licensed under the Elastic License 2.0. Copyright 2021-present, StarRocks Inc.

		#include "storage/olap_meta_reader.h"

[Feature] Support bitwise shift functions #14151

[Feature] Support bitwise shift functions #14151

Conversation

sparklezzz commented Nov 26, 2022 • edited by wangsimo0 Loading

What type of PR is this：

Which issues of this PR fixes ：

Problem Summary(Required) ：

Checklist:

Bugfix cherry-pick branch check:

CLAassistant commented Nov 26, 2022 • edited Loading

murphyatwork commented Nov 26, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot Dec 1, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 2, 2022

github-actions bot commented Dec 3, 2022

wanpengfei-git commented Dec 3, 2022

[FE PR Coverage Check]

file detail

github-actions bot commented Dec 3, 2022

sonarcloud bot commented Dec 3, 2022

murphyatwork commented Dec 3, 2022

sonarcloud bot commented Dec 3, 2022

wanpengfei-git commented Dec 6, 2022

kateshaowanjou commented Dec 7, 2022

sparklezzz commented Nov 26, 2022 •

edited by wangsimo0

Loading

CLAassistant commented Nov 26, 2022 •

edited

Loading