-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] append_trailing_char_if_absent return empty string for const empty strings #13762
[BugFix] append_trailing_char_if_absent return empty string for const empty strings #13762
Conversation
… empty strings Signed-off-by: fzhedu <[email protected]>
Please check the version labels which this pr will be auto backported to target branch and click the checkbox:
|
run starrocks_admit_test |
clang-tidy review says "All clean, LGTM! 👍" |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
run starrocks_be_unittest |
@mergify backport-2.2 |
@mergify backport-2.3 |
@mergify backport-2.4 |
@mergify backport-2.5 |
❌ No backport have been created
|
❌ No backport have been created
|
❌ No backport have been created
|
❌ No backport have been created
|
@mergify backport branch-2.5 |
@mergify backport branch-2.4 |
@mergify backport branch-2.3 |
@mergify backport branch-2.2 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
… empty strings (StarRocks#13762) (cherry picked from commit 27dd3c3)
… empty strings (#13762) (#19414) append_trailing_char_if_absent return empty string for const empty strings (cherry picked from commit 27dd3c3) Co-authored-by: Zhuhe Fang <[email protected]>
Signed-off-by: fzhedu [email protected]
What type of PR is this:
Which issues of this PR fixes :
Fixes ##12769
Problem Summary(Required) :
append_trailing_char_if_absent's behavior is different when the first arg is an empty string from columns or not.
Checklist: