Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Validate query_timeout at analyze stage #13653

Merged
merged 2 commits into from
Nov 21, 2022
Merged

[BugFix] Validate query_timeout at analyze stage #13653

merged 2 commits into from
Nov 21, 2022

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Nov 18, 2022 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #13695

Problem Summary(Required) ：

Validate query_timeout in analyze stage, with maximum value to 259200

After this pr, you will get error message when setting query_timeout with an illegal value.

> set global query_timeout=360000000;
(1064, 'query_timeout must be equal or smaller than 259200.')
> set global query_timeout=0;
(1064, 'query_timeout must be equal or greater than 1.')

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@github-actions
Copy link

Please check the version labels which this pr will be auto backported to target branch and click the checkbox:

  • check done.

@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@github-actions github-actions bot removed the be-build label Nov 18, 2022
@liuyehcf liuyehcf changed the title [BugFix] Fix overflow of some session variables like 'xxx_timeout' [BugFix] Validate query_timeout at analyze stage Nov 18, 2022
kangkaisen
kangkaisen previously approved these changes Nov 18, 2022
View reviewed changes
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Nov 18, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@liuyehcf
Copy link
Contributor Author

run starrocks_fe_unittest

@liuyehcf liuyehcf dismissed stale reviews from Seaven and kangkaisen via e9e9813 November 21, 2022 01:27
@github-actions github-actions bot removed Approved Ready to merge be-build labels Nov 21, 2022
@liuyehcf
Copy link
Contributor Author

run starrocks_admit_test

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 12 / 17 (70.59%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/LeaderOpExecutor.java 0 2 00.00% [73, 74]
🔵 com/starrocks/sql/ast/SetVar.java 11 14 78.57% [98, 169, 196]
🔵 com/starrocks/qe/SessionVariable.java 1 1 100.00% []

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Nov 21, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@liuyehcf liuyehcf enabled auto-merge (squash) November 21, 2022 04:15
@liuyehcf
Copy link
Contributor Author

run pr-title-check

@liuyehcf liuyehcf merged commit 9c5591d into StarRocks:main Nov 21, 2022
@github-actions github-actions bot removed Approved Ready to merge be-build labels Nov 21, 2022
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Nov 21, 2022
@liuyehcf
[BugFix] Validate query_timeout at analyze stage (StarRocks#13653)
8039809
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Nov 21, 2022
@liuyehcf
[BugFix] Validate query_timeout at analyze stage (StarRocks#13653)
8fbc3bd
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Nov 21, 2022
@liuyehcf
[BugFix] Validate query_timeout at analyze stage (StarRocks#13653)
768d574
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Nov 21, 2022
@liuyehcf
[BugFix] Validate query_timeout at analyze stage (StarRocks#13653)
d9610cf
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2022
@liuyehcf @wanpengfei-git
[BugFix] Validate query_timeout at analyze stage (#13653)
7247906
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2022
@liuyehcf @wanpengfei-git
[BugFix] Validate query_timeout at analyze stage (#13653)
da05d82
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2022
@liuyehcf @wanpengfei-git
[BugFix] Validate query_timeout at analyze stage (#13653)
8af98d7
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2022
@liuyehcf @wanpengfei-git
[BugFix] Validate query_timeout at analyze stage (#13653)
d2634e6
@liuyehcf
Copy link
Contributor Author

All cherry-pick prs:
#13750
#13753
#13755
#13756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HangyuanLiu HangyuanLiu HangyuanLiu left review comments

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees
No one assigned
Labels
2.2 2.3 2.4 2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] timeout can't be negative
5 participants
@liuyehcf @wanpengfei-git @Seaven @kangkaisen @HangyuanLiu