Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimize complex refresh logic in automatic refresh scenarios #13229

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[Enhancement] Optimize complex refresh logic in automatic refresh scenarios #13229

merged 1 commit into from
Nov 11, 2022

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Nov 10, 2022 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #13167

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Astralidea
Copy link
Contributor Author

run starrocks_admit_test

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 27 / 75 (36.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/TaskManager.java 0 3 00.00% [134, 135, 137]
🔵 com/starrocks/common/util/PropertyAnalyzer.java 0 10 00.00% [224, 225, 227, 228, 229, 230, 231, 232, 234, 236]
🔵 com/starrocks/qe/DDLStmtExecutor.java 0 1 00.00% [262]
🔵 com/starrocks/server/LocalMetastore.java 8 28 28.57% [3325, 3326, 3327, 3328, 3517, 3518, 3519, 3520, 3521, 3522, 3523, 3526, 3527, 3528, 3529, 3530, 3531, 3532, 3533, 3534]
🔵 com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java 2 6 33.33% [233, 486, 488, 492]
🔵 com/starrocks/sql/analyzer/AnalyzerUtils.java 3 7 42.86% [488, 489, 490, 492]
🔵 com/starrocks/catalog/MaterializedView.java 3 6 50.00% [660, 661, 662]
🔵 com/starrocks/scheduler/TaskRunContext.java 2 3 66.67% [40]
🔵 com/starrocks/catalog/TableProperty.java 7 9 77.78% [287, 288]
🔵 com/starrocks/scheduler/persist/TaskRunStatus.java 1 1 100.00% []
🔵 com/starrocks/scheduler/TaskRun.java 1 1 100.00% []

ABingHuang
ABingHuang approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ABingHuang ABingHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Astralidea Astralidea enabled auto-merge (squash) November 11, 2022 02:02
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Nov 11, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@Astralidea Astralidea merged commit e81f9ee into StarRocks:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youngwb Youngwb Youngwb approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

@ABingHuang ABingHuang ABingHuang approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge be-build behavior_changed sig/materialized view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the refresh scenario of large wide tables
5 participants
@Astralidea @wanpengfei-git @Youngwb @gengjun-git @ABingHuang