[Feature] Unnest supports multiple parameters of different types #12484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
starrocks_be_unittest succeeded. |
liuyehcf
reviewed
Oct 26, 2022
|
starrocks_be_unittest succeeded. |
|
starrocks_be_unittest succeeded. |
packy92
reviewed
Oct 27, 2022
| @@ -49,8 +54,7 @@ public TableFunction(FunctionName fnName, List<String> defaultColumnNames, List< | |||
|
|
|||
| public static void initBuiltins(FunctionSet functionSet) { | |||
| TableFunction unnestFunction = new TableFunction(new FunctionName("unnest"), Lists.newArrayList("unnest"), | |||
| Lists.newArrayList(Type.ANY_ARRAY), Lists.newArrayList(Type.ANY_ELEMENT)); | |||
|
|
|||
| Lists.newArrayList(Type.ANY_ARRAY), Lists.newArrayList(Type.ANY_ELEMENT), true); | |||
There was a problem hiding this comment.
In line 91 of Function.java, there is a todo like TODO: we don't currently support varargs with no fixed types. i.e. fn(...). Can this todo be removed after this pr merged?
There was a problem hiding this comment.
No, that comment is for scalar function, and scalar function does not currently support multi-type case.
kangkaisen
reviewed
Oct 27, 2022
kangkaisen
reviewed
Oct 27, 2022
fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeLateralTest.java
Show resolved
Hide resolved
|
BE Build Success |
kangkaisen
reviewed
Nov 1, 2022
fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java
Outdated
Show resolved
Hide resolved
kangkaisen
reviewed
Nov 1, 2022
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/QueryAnalyzer.java
Outdated
Show resolved
Hide resolved
kangkaisen
previously approved these changes
Nov 1, 2022
|
BE Build Success |
liuyehcf
reviewed
Nov 2, 2022
liuyehcf
approved these changes
Nov 2, 2022
|
Kudos, SonarCloud Quality Gate passed! |
kangkaisen
approved these changes
Nov 2, 2022
|
SonarCloud Quality Gate failed.
|
|
run starrocks_fe_unittest |
[FE PR Coverage Check]😍 pass : 55 / 56 (98.21%) file detail
|
|
run starrocks_admit_test |
choury
added a commit
that referenced
this pull request
Jun 12, 2023
choury
pushed a commit
that referenced
this pull request
Jun 12, 2023
[Feature] Unnest supports multiple parameters of different types #12484 unnest支持多列展开 ``` select * from tb1; +------+-------------------+-------------------+ | id | type1 | type2 | +------+-------------------+-------------------+ | id1 | typeA;typeB;typeC | type1;type2;type3 | +------+-------------------+-------------------+ select id, t1.v1, t1.v2 from tb1, unnest(split(type1, ";"), split(type2, ";")) as t1(v1, v2); +------+-------+-------+ | id | v1 | v2 | +------+-------+-------+ | id1 | typeA | type1 | | id1 | typeB | type2 | | id1 | typeC | type3 | +------+-------+-------+ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
The Unnest function supports multiple parameters, and the lengths of multiple arrays in unnest may not be equal. When there is an unequal situation, the columns expanded by the few arrays are supplemented with NULL values.
https://github.com/StarRocks/StarRocksTest/pull/1354
Checklist: