Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement HiveStatisticsProvider #11599

Merged
merged 1 commit into from
Sep 25, 2022
Merged

[Feature] Implement HiveStatisticsProvider #11599

merged 1 commit into from
Sep 25, 2022

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Sep 23, 2022 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #
#11349

Problem Summary(Required) ：

Provide a statistics provider to calculator hive or hudi table statistics

Checklist:

  • I have added test cases for my bug fix or my new feature
  • I have added user document for my new feature or new function

@stephen-shelby
Copy link
Contributor Author

run starrocks_admit_test

@stephen-shelby
Copy link
Contributor Author

run starrocks_admit_test

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
4.3% 4.3% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 204 / 248 (82.26%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/external/hive/HiveStatisticsProvider.java 202 246 82.11% [68, 69, 117, 118, 172, 173, 182, 183, 184, 186, 187, 188, 190, 225, 250, 251, 252, 253, 255, 293, 323, 337, 349, 350, 351, 352, 353, 355, 356, 359, 360, 361, 362, 364, 366, 417, 420, 422, 427, 430, 432, 440, 443, 468]
🔵 com/starrocks/qe/SessionVariable.java 2 2 100.00% []

@stephen-shelby
Copy link
Contributor Author

run starrocks_admit_test

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Sep 25, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@Astralidea Astralidea enabled auto-merge (squash) September 25, 2022 03:40
@Astralidea Astralidea merged commit 70feb80 into StarRocks:main Sep 25, 2022
@stephen-shelby stephen-shelby deleted the hms_stats branch September 25, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorianZheng DorianZheng DorianZheng left review comments

@Astralidea Astralidea Astralidea approved these changes

@Youngwb Youngwb Youngwb approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephen-shelby @wanpengfei-git @Astralidea @DorianZheng @Youngwb