-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support write quorum property for table #11253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howrocks
reviewed
Sep 17, 2022
howrocks
reviewed
Sep 17, 2022
fe/fe-core/src/main/java/com/starrocks/load/loadv2/BulkLoadJob.java
Outdated
Show resolved
Hide resolved
meegoo
changed the title
[Feature] Support insert quorum config
[Feature] Support write quorum properties for table
Sep 19, 2022
meegoo
changed the title
[Feature] Support write quorum properties for table
[Feature] Support write quorum property for table
Sep 19, 2022
meegoo
force-pushed
the
insert_quorum
branch
4 times, most recently
from
September 19, 2022 19:08
b987aaa
to
74cca3e
Compare
meegoo
force-pushed
the
insert_quorum
branch
2 times, most recently
from
September 19, 2022 20:15
81bedb6
to
781d872
Compare
howrocks
reviewed
Sep 20, 2022
howrocks
reviewed
Sep 20, 2022
fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadingTaskPlanner.java
Show resolved
Hide resolved
howrocks
reviewed
Sep 20, 2022
run starrocks_fe_unittest |
chaoyli
reviewed
Sep 21, 2022
meegoo
force-pushed
the
insert_quorum
branch
3 times, most recently
from
September 28, 2022 07:46
6dc9e4f
to
b776814
Compare
run starrocks_fe_unittest |
run starrocks_admit_test |
run starrocks_fe_unittest |
1 similar comment
run starrocks_fe_unittest |
run starrocks_admit_test |
gengjun-git
previously approved these changes
Oct 10, 2022
run starrocks_fe_unittest |
run starrocks_admit_test |
run starrocks_admit_test |
1. MAJORITY: write majority replica successfully returns success, default option 2. ONE: write one replica successfully returns success 3. ALL: write all replica successfully returns success
run starrocks_admit_test |
[FE PR Coverage Check]😞 fail : 76 / 116 (65.52%) file detail
|
Kudos, SonarCloud Quality Gate passed! |
chaoyli
approved these changes
Oct 12, 2022
gengjun-git
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #11613
Problem Summary(Required) :
User can set
write_quorum
to specify replica write strategy when create/alter table.MAJORITY: write majority replica successfully returns success, default option
ONE: write one replica successfully returns success
ALL: write all replica successfully returns success
CREATE TABLE
ALTER TABLE
Checklist: