-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]implement Lambda array_filter() #10323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhedu
force-pushed
the
lambdaArrayFilter
branch
3 times, most recently
from
September 3, 2022 15:06
7b8f704
to
04a5f2d
Compare
kangkaisen
reviewed
Sep 5, 2022
kangkaisen
reviewed
Sep 5, 2022
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/FunctionAnalyzer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: fzhedu <[email protected]>
Signed-off-by: fzhedu <[email protected]>
fzhedu
force-pushed
the
lambdaArrayFilter
branch
from
September 5, 2022 09:14
04a5f2d
to
0e8a23e
Compare
Signed-off-by: fzhedu <[email protected]>
[FE PR Coverage Check]😍 pass : 51 / 53 (96.23%) file detail
|
Kudos, SonarCloud Quality Gate passed! |
kangkaisen
approved these changes
Sep 6, 2022
murphyatwork
approved these changes
Sep 6, 2022
@@ -27,7 +27,7 @@ public static void analyze(FunctionCallExpr functionCallExpr) { | |||
} | |||
|
|||
FunctionName fnName = functionCallExpr.getFnName(); | |||
if (fnName.getFunction().equalsIgnoreCase(FunctionSet.DATE_TRUNC)) { | |||
if (fnName.getFunction().equals(FunctionSet.DATE_TRUNC)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested by #10323 (comment)
run starrocks_admit_test |
satanson
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #
Problem Summary(Required) :
array_filter(array, array_bool) use array_bool to filter array, where the array_bool item is not null or not zero.
if array_bool.size() != array.size(), the result array is decided by the valid items within min(array_bool, array).
if the array_bool is NULL, it does filter all elements by design.
if any of array or array_bool is const null, return null directly.
for example:
Checklist: