Use CoreLocalCounter

Signed-off-by: PengFei Li <[email protected]>
StarRocks · Mar 11, 2024 · 20c300b · 20c300b
1 parent acec610
commit 20c300b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/be/src/util/threadpool.cpp b/be/src/util/threadpool.cpp
@@ -571,11 +571,9 @@ void ThreadPool::dispatch_thread() {
         task.runnable.reset();
         MonoTime finish_time = MonoTime::Now();
 
-        _total_executed_tasks.fetch_add(1, std::memory_order_relaxed);
-        _total_pending_time_ns.fetch_add(start_time.GetDeltaSince(task.submit_time).ToNanoseconds(),
-                                         std::memory_order_relaxed);
-        _total_execute_time_ns.fetch_add(finish_time.GetDeltaSince(start_time).ToNanoseconds(),
-                                         std::memory_order_relaxed);
+        _total_executed_tasks.increment(1);
+        _total_pending_time_ns.increment(start_time.GetDeltaSince(task.submit_time).ToNanoseconds());
+        _total_execute_time_ns.increment(finish_time.GetDeltaSince(start_time).ToNanoseconds());
 
         l.lock();
         _last_active_timestamp = MonoTime::Now();

diff --git a/be/src/util/threadpool.h b/be/src/util/threadpool.h
@@ -53,6 +53,7 @@
 #include "util/bthreads/semaphore.h"
 // resolve `barrier` macro conflicts with boost/thread.hpp header file
 #undef barrier
+#include "util/metrics.h"
 #include "util/monotime.h"
 #include "util/priority_queue.h"
 
@@ -248,11 +249,11 @@ class ThreadPool {
 
     int max_threads() const { return _max_threads.load(std::memory_order_acquire); }
 
-    int64_t total_executed_tasks() const { return _total_executed_tasks.load(); }
+    int64_t total_executed_tasks() const { return _total_executed_tasks.value(); }
 
-    int64_t total_pending_time_ns() const { return _total_pending_time_ns.load(); }
+    int64_t total_pending_time_ns() const { return _total_pending_time_ns.value(); }
 
-    int64_t total_execute_time_ns() const { return _total_execute_time_ns.load(); }
+    int64_t total_execute_time_ns() const { return _total_execute_time_ns.value(); }
 
 private:
     friend class ThreadPoolBuilder;
@@ -379,13 +380,13 @@ class ThreadPool {
     std::unique_ptr<ThreadPoolToken> _tokenless;
 
     // Total number of tasks that have finished
-    std::atomic<int64_t> _total_executed_tasks;
+    CoreLocalCounter<int64_t> _total_executed_tasks{MetricUnit::NOUNIT};
 
     // Total time in nanoseconds that tasks pending in the queue.
-    std::atomic<int64_t> _total_pending_time_ns;
+    CoreLocalCounter<int64_t> _total_pending_time_ns{MetricUnit::NOUNIT};
 
     // Total time in nanoseconds to execute tasks.
-    std::atomic<int64_t> _total_execute_time_ns;
+    CoreLocalCounter<int64_t> _total_execute_time_ns{MetricUnit::NOUNIT};
 
     ThreadPool(const ThreadPool&) = delete;
     const ThreadPool& operator=(const ThreadPool&) = delete;