Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix HPA deletion failed on GKE #444

Conversation

yandongxiao
Copy link
Collaborator

@yandongxiao yandongxiao commented Feb 5, 2024

Description

Fixes: #420

the root cause is In GKE environment, the Minor version is not a number, like v1.27.3-gke.100.

Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3-gke.100", GitCommit:"6466b51b762a5c49ae3fb6c2c7233ffe1c96e48c", GitTreeState:"clean", BuildDate:"2023-06-23T09:27:28Z", GoVersion:"go1.20.5 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}

How do I fix the issue? In StarRocksCluster CR status, there are fields about HPA.

    horizontalScaler:
      name: kube-starrocks-cn-autoscaler
      version: v2

we can first use this version to delete the HPA resource.

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

@yandongxiao yandongxiao force-pushed the bugfix/fix-failed-to-delete-hpa-in-gke branch from af6e3ec to b9dfc9f Compare February 5, 2024 03:31
@yandongxiao yandongxiao marked this pull request as ready for review February 5, 2024 04:33
@yandongxiao yandongxiao merged commit 7d45e6b into StarRocks:main Mar 4, 2024
5 checks passed
@yandongxiao yandongxiao added v1.9.3 bugfix fix something that does not work labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fix something that does not work v1.9.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StarRocks Operator always checks for Auto Scaling, even if the config is not present in the StarRocksCluster
1 participant