Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Add labels of service to up metrics of Prometheus to support grafana dashboard #433

Conversation

yandongxiao
Copy link
Collaborator

Description

When StarRocks metrics is scraped by ServiceMonitor, there will not have app_starrocks_ownerreference_name or app_kubernetes_io_component labels in up metrics. This will lead to grafana dashboard not working correctly.

Checklist

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao yandongxiao changed the title [BugFix] Add Service Labels to up metrics of Prometheus to support grafana dashboard [BugFix] Add labels of service to up metrics of Prometheus to support grafana dashboard Feb 1, 2024
@yandongxiao yandongxiao changed the title [BugFix] Add labels of service to up metrics of Prometheus to support grafana dashboard [BugFix] Add labels of service to up metrics of Prometheus to support grafana dashboard Feb 1, 2024
@yandongxiao yandongxiao merged commit 2f250ec into StarRocks:main Feb 1, 2024
4 checks passed
@yandongxiao yandongxiao added v1.9.2 bugfix fix something that does not work labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fix something that does not work v1.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants