[Enhancement] Support to specify warehouse for sr flink source connector#423
Merged
Merged
Conversation
Signed-off-by: zhangbutao <zhangbutao@cmss.chinamobile.com>
Closed
24 tasks
kevincai
reviewed
Apr 16, 2025
| HttpPost post = new HttpPost(url); | ||
| post.setHeader("Content-Type", "application/json;charset=UTF-8"); | ||
| post.setHeader("Authorization", getBasicAuthHeader(sourceOptions.getUsername(), sourceOptions.getPassword())); | ||
| post.setHeader("warehouse", sourceOptions.getWarehouseName()); |
There was a problem hiding this comment.
what's the default value if the specific key is not configured?
Signed-off-by: zhangbutao <zhangbutao@cmss.chinamobile.com>
zhangbutao
commented
Apr 16, 2025
| post.setHeader("Content-Type", "application/json;charset=UTF-8"); | ||
| post.setHeader("Authorization", getBasicAuthHeader(sourceOptions.getUsername(), sourceOptions.getPassword())); | ||
| Optional.ofNullable(sourceOptions.getWarehouseName()) | ||
| .ifPresent(warehouse -> post.setHeader("warehouse", warehouse)); |
Contributor
Author
There was a problem hiding this comment.
@kevincai I refine this code to avoid setting warehouse header(null value) in case of flink sink table not having 'scan.params.warehouse'='warehosue_name'. And then fe will use the default_warehouse if not getting the warehouse header.
kevincai
approved these changes
Apr 16, 2025
Contributor
Author
|
Can we merge this change? @kevincai |
banmoy
approved these changes
Jun 13, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
This PR is used for StarRocks/starrocks#57930
Support to specify warehouse for sr flink source connector using param `'scan.params.warehouse'='warehosue_name', and then pass the warehouse to fe through http header.
`
Fixes #
Problem Summary(Required) :
Checklist: