Skip to content

[Bugfix] Prepare failed when the transaction still in processing #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gohalo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix] Prepare failed when the transaction still in processing #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...cks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/StreamLoadConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public interface StreamLoadConstants {
String RESULT_STATUS_FAILED = "Fail";
String RESULT_STATUS_LABEL_EXISTED = "Label Already Exists";
String RESULT_STATUS_TRANSACTION_NOT_EXISTED = "TXN_NOT_EXISTS";
String RESULT_STATUS_TRANSACTION_IN_PROCESSING = "TXN_IN_PROCESSING";
String RESULT_STATUS_TRANSACTION_COMMIT_TIMEOUT = "Commit Timeout";
String RESULT_STATUS_TRANSACTION_PUBLISH_TIMEOUT = "Publish Timeout";

Expand Down
10 changes: 10 additions & 0 deletions ...stream-load-sdk/src/main/java/com/starrocks/data/load/stream/TransactionStreamLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,12 @@ public boolean prepare(StreamLoadSnapshot.Transaction transaction) {
} else {
return true;
}
case StreamLoadConstants.RESULT_STATUS_TRANSACTION_IN_PROCESSING:
String warnMsg = String.format("Transaction in processing, db: %s, table: %s, label: %s, " +
"\nresponseBody: %s", transaction.getDatabase(), transaction.getTable(),
transaction.getLabel(), responseBody);
log.warn(warnMsg);
return false;
}
}

Expand Down Expand Up @@ -275,6 +281,10 @@ public boolean commit(StreamLoadSnapshot.Transaction transaction) {
responseBody));
}

if (StreamLoadConstants.RESULT_STATUS_TRANSACTION_IN_PROCESSING.equals(status)) {
log.info("Transaction in processing, retry later, lable: {}, body : {}", transaction.getLabel(), responseBody);
return false;
}

if (StreamLoadConstants.RESULT_STATUS_OK.equals(status)) {
manager.callback(streamLoadResponse);
Expand Down