Skip to content

[BugFix] Resolve Delete Semantics Data Loss in Flink SQL for StarRocks 3.1 #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andystenhe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BugFix] Resolve Delete Semantics Data Loss in Flink SQL for StarRocks 3.1 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a61f923
[BugFix] In the 3.1 separated storage and computation version, the us…
andystenhe May 24, 2024
6a60205
Merge branch 'StarRocks:main' into main
andystenhe Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/main/java/com/starrocks/connector/flink/manager/StarRocksSinkManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,21 +424,8 @@ private void validateTableStructure(TableSchema flinkSchema) {
}
// validate primary keys
List<String> primayKeys = new ArrayList<>();
for (int i = 0; i < rows.size(); i++) {
String keysType = rows.get(i).get("COLUMN_KEY").toString();
if (!"PRI".equals(keysType)) {
continue;
}
primayKeys.add(rows.get(i).get("COLUMN_NAME").toString().toLowerCase());
}
flinkSchema.getPrimaryKey().ifPresent(c -> c.getColumns().forEach(colName -> primayKeys.add(colName.toLowerCase())));
if (!primayKeys.isEmpty()) {
if (!constraint.isPresent()) {
throw new IllegalArgumentException("Primary keys not defined in the sink `TableSchema`.");
}
if (constraint.get().getColumns().size() != primayKeys.size() ||
!constraint.get().getColumns().stream().allMatch(col -> primayKeys.contains(col.toLowerCase()))) {
throw new IllegalArgumentException("Primary keys of the flink `TableSchema` do not match with the ones from starrocks table.");
}
sinkOptions.enableUpsertDelete();
}

Expand Down
15 changes: 1 addition & 14 deletions src/main/java/com/starrocks/connector/flink/manager/StarRocksSinkTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,21 +102,8 @@ public void validateTableStructure(StarRocksSinkOptions sinkOptions, TableSchema
}
// validate primary keys
List<String> primaryKeys = new ArrayList<>();
for (Map<String, Object> row : rows) {
String keysType = row.get("COLUMN_KEY").toString();
if (!"PRI".equals(keysType)) {
continue;
}
primaryKeys.add(row.get("COLUMN_NAME").toString().toLowerCase());
}
flinkSchema.getPrimaryKey().ifPresent(c -> c.getColumns().forEach(colName -> primaryKeys.add(colName.toLowerCase())));
if (!primaryKeys.isEmpty()) {
if (!constraint.isPresent()) {
throw new IllegalArgumentException("Primary keys not defined in the sink `TableSchema`.");
}
if (constraint.get().getColumns().size() != primaryKeys.size() ||
!constraint.get().getColumns().stream().allMatch(col -> primaryKeys.contains(col.toLowerCase()))) {
throw new IllegalArgumentException("Primary keys of the flink `TableSchema` do not match with the ones from starrocks table.");
}
sinkOptions.enableUpsertDelete();
}

Expand Down