Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New robot (R1 & A1) with robot fixes #868

Merged
merged 21 commits into from
Sep 18, 2024
Merged

New robot (R1 & A1) with robot fixes #868

merged 21 commits into from
Sep 18, 2024

Conversation

wensi-ai
Copy link
Contributor

@wensi-ai wensi-ai commented Sep 7, 2024

No description provided.

@wensi-ai wensi-ai self-assigned this Sep 7, 2024
@wensi-ai wensi-ai changed the title New robot (R1 & A1) New robot (R1 & A1) with robot fixes Sep 7, 2024
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
cremebrule
cremebrule reviewed Sep 7, 2024
View reviewed changes
Copy link
Contributor

@cremebrule cremebrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, a few minor comments!

ChengshuLi
ChengshuLi reviewed Sep 10, 2024
View reviewed changes
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Show resolved Hide resolved
omnigibson/robots/tiago.py Outdated Show resolved Hide resolved
omnigibson/robots/a1.py Outdated Show resolved Hide resolved
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
omnigibson/robots/r1.py Show resolved Hide resolved
omnigibson/robots/r1.py Outdated Show resolved Hide resolved
@cremebrule cremebrule self-requested a review September 17, 2024 21:12
cremebrule
cremebrule approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cremebrule cremebrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM! A couple minor comments. We should also add the new robots + new robot classes to our docs!

@ChengshuLi ChengshuLi merged commit 1a671f8 into og-develop Sep 18, 2024
21 checks passed
@ChengshuLi ChengshuLi deleted the new-robot branch September 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengshuLi ChengshuLi ChengshuLi left review comments

@cremebrule cremebrule cremebrule approved these changes

@cgokmen cgokmen Awaiting requested review from cgokmen

Assignees

@wensi-ai wensi-ai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wensi-ai @ChengshuLi @cremebrule